Changeset View
Standalone View
security/ktls_isa-l_crypto-kmod/Makefile
| Show All 27 Lines | |||||
| PLIST_FILES= ${KMODDIR}/ktls_intel-isa-l.ko | PLIST_FILES= ${KMODDIR}/ktls_intel-isa-l.ko | ||||
| .include <bsd.port.pre.mk> | .include <bsd.port.pre.mk> | ||||
| .if !exists(${SRC_BASE}/sys/sys/ktls.h) | .if !exists(${SRC_BASE}/sys/sys/ktls.h) | ||||
| IGNORE= requires KTLS support | IGNORE= requires KTLS support | ||||
| .endif | .endif | ||||
| .if ${OSVERSION} >= 1400016 | |||||
sbz: We tend to use `OSVERSION` (integer) instead of `OSREL` (string) across the port tree to test… | |||||
Not Done Inline ActionsDoesn't this need to be .if ${OSVERSION} >= 1300000 && ${OSVERSION} < 1400000? imp: Doesn't this need to be
```
.if ${OSVERSION} >= 1300000 && ${OSVERSION} < 1400000
```
? | |||||
Not Done Inline ActionsYes if it's only for 13.x, I don't have the full context here. I wanted just to report the use of OSVERSION instead. sbz: Yes if it's only for 13.x, I don't have the full context here. I wanted just to report the use… | |||||
Done Inline ActionsAh, I had patterned this on the existing IGNORE functionality which uses OSREL: https://github.com/freebsd/freebsd-ports/blob/main/Mk/bsd.port.mk#L163 What I really need is a 'ONLY_FOR_${OPSYS}_${OSREL:R}' type functionality, but we don't have that, only the inverse (IGNORE_${OPSYS}_${OSREL:R}). It is somewhat confusing to use OSREL when working with major versions (as this chunk here is and as all the BROKEN_* and IGNORE_* helpers do) and OSVERSION at other times. In this case, I don't have a specific range of OSVERSION values to check for, but I guess can add another bump for just this port (it's the only one that cares). jhb: Ah, I had patterned this on the existing IGNORE functionality which uses OSREL:
https://github. | |||||
| IGNORE= is only supported on FreeBSD 13 | |||||
| .endif | |||||
| post-extract: | post-extract: | ||||
| ${CP} ${FILESDIR}/* ${WRKSRC}/ | ${CP} ${FILESDIR}/* ${WRKSRC}/ | ||||
| ${ECHO} "#include <sys/stdint.h>" > ${WRKSRC}/include/stdint.h | ${ECHO} "#include <sys/stdint.h>" > ${WRKSRC}/include/stdint.h | ||||
| .include <bsd.port.post.mk> | .include <bsd.port.post.mk> | ||||
We tend to use OSVERSION (integer) instead of OSREL (string) across the port tree to test for version requirements. You can the definition here cf. OSVERSION