Changeset View
Standalone View
graphics/drm-kmod/Makefile
| Show All 10 Lines | |||||
| USES= metaport | USES= metaport | ||||
| .include <bsd.port.options.mk> | .include <bsd.port.options.mk> | ||||
| .if ${OPSYS} != FreeBSD | .if ${OPSYS} != FreeBSD | ||||
| IGNORE= not supported on anything but FreeBSD (missing linuxkpi functionality) | IGNORE= not supported on anything but FreeBSD (missing linuxkpi functionality) | ||||
| .else | .else | ||||
| .if ${ARCH} != "amd64" | .if ${ARCH} != "amd64" | ||||
| .if ${OSVERSION} >= 1200080 | .if ${OSVERSION} >= 1201000 | ||||
mandree: Please do not update this - versions >= 1200080 and < 1201000 do not magically change their… | |||||
mandreeUnsubmitted Not Done Inline Actions
This comment stands, please drop this change. The behaviour of, say, exactly 1200080, does not change, so we should not clobber this knowledge of when *exactly* the kmod became needed. It will only confuse people trying to understand "why 1201000" because the OSVERSION you check is now detached from the actual OSVERSION that correlates with the change. mandree: > Please do not update this - versions >= 1200080 and < 1201000 do not magically change their… | |||||
Not Done Inline Actions@rene Again, please omit these changes to graphics/drm-kmod/Makefile, as @zeising also pointed out. You are checking features of historic kernels here, not ports tree, and existing kernel features don't change because someone pulls the plug on the ports tree. You don't really attain simplification here, just leave this file untouched. Let's clean this up after the entire 11 branch is EOL. mandree: @rene Again, please omit these changes to `graphics/drm-kmod/Makefile`, as @zeising also… | |||||
| RUN_DEPENDS= ${KMODDIR}/drm.ko:graphics/drm-legacy-kmod | RUN_DEPENDS= ${KMODDIR}/drm.ko:graphics/drm-legacy-kmod | ||||
| .elif ${OSVERSION} < 1200080 | .else | ||||
| IGNORE= legacy kmod not required on less than 12.0 | IGNORE= legacy kmod not required on less than 12.1 | ||||
zeisingUnsubmitted Not Done Inline ActionsThis comment is technically not true. zeising: This comment is technically not true.
I'm not sure if it'suseful to update the version check to… | |||||
| .endif | .endif | ||||
| .else | .else | ||||
| .if ${OSVERSION} >= 1103000 && ${OSVERSION} < 1200000 | .if ${OSVERSION} >= 1104000 && ${OSVERSION} < 1200000 | ||||
| RUN_DEPENDS= ${KMODDIR}/drm.ko:graphics/drm-fbsd11.2-kmod | RUN_DEPENDS= ${KMODDIR}/drm.ko:graphics/drm-fbsd11.2-kmod | ||||
| .elif ${OSVERSION} >= 1200058 && ${OSVERSION} < 1300000 | .elif ${OSVERSION} >= 1201000 && ${OSVERSION} < 1300000 | ||||
| RUN_DEPENDS= ${KMODDIR}/drm.ko:graphics/drm-fbsd12.0-kmod | RUN_DEPENDS= ${KMODDIR}/drm.ko:graphics/drm-fbsd12.0-kmod | ||||
| .elif ${OSVERSION} >= 1300000 && ${OSVERSION} < 1300108 | .elif ${OSVERSION} >= 1300000 && ${OSVERSION} < 1300108 | ||||
| IGNORE= not supported on older 13, no kernel support | IGNORE= not supported on older 13, no kernel support | ||||
| .elif ${OSVERSION} >= 1300108 | .elif ${OSVERSION} >= 1300108 | ||||
| RUN_DEPENDS= ${KMODDIR}/drm.ko:graphics/drm-current-kmod | RUN_DEPENDS= ${KMODDIR}/drm.ko:graphics/drm-current-kmod | ||||
| .else | .else | ||||
| IGNORE= not supported for this configuration | IGNORE= not supported for this configuration | ||||
| .endif | .endif | ||||
| .endif | .endif | ||||
| .endif | .endif | ||||
| .include <bsd.port.mk> | .include <bsd.port.mk> | ||||
Please do not update this - versions >= 1200080 and < 1201000 do not magically change their behaviour, so again this check should not be changed. Even if you think that it can no longer be activated, let's not make review of "why did we did this or that in the past" kind more difficult and mislead people reading history.