Page MenuHomeFreeBSD
Differential D23938 Diff 69320 net-p2p/mt-recorder/Makefile

Changeset View

Standalone View

View Options

net-p2p/mt-recorder/Makefile

  • This file was added.
PropertyOld ValueNew Value
svn:eol-stylenullnative
\ No newline at end of property
svn:keywordsnullFreeBSD=%H
\ No newline at end of property
svn:mime-typenulltext/plain
\ No newline at end of property
# $FreeBSD$
PORTNAME= mt-recorder
PORTVERSION= 0.5.3
DISTVERSIONPREFIX= v
CATEGORIES= net-p2p
MAINTAINER= hsw@bitmark.com
COMMENT= Multi-threaded hasher for Bitmark blockchain
LICENSE= BSD2CLAUSE
LICENSE_FILE= ${WRKSRC}/LICENSE
BUILD_DEPENDS= llvm${LLVM_DEFAULT}>=0:devel/llvm${LLVM_DEFAULT}
LIB_DEPENDS= libzmq.so:net/libzmq4
tobikUnsubmitted
Not Done
Inline Actions

Wrong order. See https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-order.html

Also please do not lock it to llvm80 and use ${LLVM_DEFAULT} here.

tobik: Wrong order. See https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting…
USES= cargo
tobikUnsubmitted
Not Done
Inline Actions

This should probably be an option not a flavor. When compiled with SIMD support the argonautica crate passes -march=native to the build [1], which means the package would be specific to the package builder hardware, i.e., the package would be broken on a large number of systems [2]. It is a waste of resources to build such packages.

[1] https://github.com/bcmyers/argonautica/blob/v0.2.0/argonautica-rs/build.rs#L67
[2] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-arch.html

tobik: This should probably be an option not a flavor. When compiled with SIMD support the…
OPTIONS_DEFINE= SIMD
mikaelUnsubmitted
Not Done
Inline Actions

simd exists on arm*, ppc*. Is it limited to amd64?

mikael: simd exists on arm*, ppc*. Is it limited to amd64?
OPTIONS_SUB= yes
SIMD_DESC= Enable optimised code using AVX instructions
.include <bsd.port.options.mk>
tobikUnsubmitted
Not Done
Inline Actions

USES=pkgconfig is already implied by CARGO_CRATES=pkgconfig. Please remove it.

tobik: USES=pkgconfig is already implied by CARGO_CRATES=pkgconfig. Please remove it.
USE_GITHUB= yes
GH_ACCOUNT= hxw
CARGO_CRATES= adler32-1.0.4 \
aho-corasick-0.7.9 \
ansi_term-0.11.0 \
antidote-1.0.0 \
arc-swap-0.4.4 \
argonautica-0.2.0 \
atty-0.2.14 \
autocfg-0.1.7 \
autocfg-1.0.0 \
backtrace-0.3.44 \
backtrace-sys-0.1.32 \
base64-0.10.1 \
base64-0.11.0 \
base64-serde-0.4.0 \
bindgen-0.48.1 \
bitflags-1.2.1 \
bstr-0.2.11 \
byteorder-1.3.4 \
bytes-0.5.4 \
cc-1.0.50 \
cexpr-0.3.5 \
cfg-if-0.1.10 \
chrono-0.4.10 \
clang-sys-0.26.4 \
clap-2.33.0 \
cloudabi-0.0.3 \
crc32fast-1.2.0 \
dtoa-0.4.5 \
env_logger-0.6.2 \
error-chain-0.10.0 \
failure-0.1.5 \
failure_derive-0.1.6 \
flate2-1.0.13 \
fnv-1.0.6 \
fuchsia-cprng-0.1.1 \
futures-0.1.29 \
futures-cpupool-0.1.8 \
glob-0.2.11 \
hashbrown-0.1.8 \
hermit-abi-0.1.8 \
hex-0.3.2 \
hex-0.4.2 \
hex-serde-0.1.0 \
humantime-1.3.0 \
itoa-0.4.5 \
jobserver-0.1.21 \
lazy_static-1.4.0 \
libc-0.2.67 \
libloading-0.5.2 \
linked-hash-map-0.5.2 \
log-0.4.8 \
log-mdc-0.1.0 \
log4rs-0.10.0 \
memchr-2.3.3 \
metadeps-1.1.2 \
miniz_oxide-0.3.6 \
nom-4.2.3 \
num-integer-0.1.42 \
num-traits-0.2.11 \
num_cpus-1.12.0 \
ordered-float-1.0.2 \
peeking_take_while-0.1.2 \
pkg-config-0.3.17 \
proc-macro2-0.4.30 \
proc-macro2-1.0.9 \
quick-error-1.2.3 \
quote-0.6.13 \
quote-1.0.2 \
rand-0.4.6 \
rand-0.6.5 \
rand_chacha-0.1.1 \
rand_core-0.3.1 \
rand_core-0.4.2 \
rand_hc-0.1.0 \
rand_isaac-0.1.1 \
rand_jitter-0.1.4 \
rand_os-0.1.3 \
rand_pcg-0.1.2 \
rand_xorshift-0.1.1 \
rdrand-0.4.0 \
redox_syscall-0.1.56 \
regex-1.3.3 \
regex-syntax-0.6.16 \
remove_dir_all-0.5.2 \
rlua-0.17.0 \
rustc-demangle-0.1.16 \
ryu-1.0.2 \
scopeguard-0.3.3 \
scopeguard-1.1.0 \
serde-1.0.104 \
serde-aux-0.6.1 \
serde-value-0.6.0 \
serde_derive-1.0.104 \
serde_json-1.0.48 \
serde_yaml-0.8.11 \
simple-error-0.2.1 \
spmc-0.3.0 \
strsim-0.8.0 \
syn-1.0.16 \
synstructure-0.12.3 \
tempdir-0.3.7 \
termcolor-1.1.0 \
textwrap-0.11.0 \
thread-id-3.3.0 \
thread_local-1.0.1 \
time-0.1.42 \
toml-0.2.1 \
traitobject-0.1.0 \
typemap-0.3.3 \
unicode-width-0.1.7 \
unicode-xid-0.1.0 \
unicode-xid-0.2.0 \
unsafe-any-0.4.2 \
vec_map-0.8.1 \
version_check-0.1.5 \
which-2.0.1 \
winapi-0.3.8 \
winapi-i686-pc-windows-gnu-0.4.0 \
winapi-util-0.1.3 \
winapi-x86_64-pc-windows-gnu-0.4.0 \
yaml-rust-0.3.5 \
yaml-rust-0.4.3 \
zmq-0.9.2 \
zmq-sys-0.11.0
.if ${PORT_OPTIONS:MSIMD}
CARGO_FEATURES+= simd
.endif
tobikUnsubmitted
Not Done
Inline Actions

Nop with USES=cargo ports. Please remove it.

If the binary needs to be stripped put a ${STRIP_CMD} in post-install.

tobik: Nop with USES=cargo ports. Please remove it. If the binary needs to be stripped put a…
USE_RC_SUBR= mt-recorder
USERS= mt-recorder
GROUPS= mt-recorder
VAR_DIR= /var
MT_RECORDER_RUN= ${VAR_DIR}/run/mt-recorder
MT_RECORDER_DATA= ${VAR_DIR}/lib/mt-recorder
SUB_LIST= MT_RECORDER_USER=mt-recorder \
MT_RECORDER_GROUP=mt-recorder \
MT_RECORDER_RUN=${MT_RECORDER_RUN} \
MT_RECORDER_DATA=${MT_RECORDER_DATA}
PLIST_FILES= sbin/${PORTNAME} \
"@sample etc/${PORTNAME}.conf.sample" \
tobikUnsubmitted
Not Done
Inline Actions

There is no reason to use += anywhere in this port.

tobik: There is no reason to use `+=` anywhere in this port.
etc/syslog.d/${PORTNAME}.conf \
etc/newsyslog.conf.d/${PORTNAME}.conf \
"@dir ${VAR_DIR}/lib" \
"@dir(mt-recorder,mt-recorder,) ${MT_RECORDER_DATA}" \
"@dir(mt-recorder,mt-recorder,) ${MT_RECORDER_RUN}"
post-install:
${MKDIR} ${STAGEDIR}${MT_RECORDER_RUN}
${MKDIR} ${STAGEDIR}${MT_RECORDER_DATA}
${MV} ${STAGEDIR}${PREFIX}/bin/* ${STAGEDIR}${PREFIX}/sbin/
${INSTALL_DATA} ${WRKSRC}/${PORTNAME}.conf.sample ${STAGEDIR}${PREFIX}/etc/
tobikUnsubmitted
Not Done
Inline Actions

No need for the quotes.

tobik: No need for the quotes.
${MKDIR} ${STAGEDIR}${PREFIX}/etc/syslog.d
${MKDIR} ${STAGEDIR}${PREFIX}/etc/newsyslog.conf.d
${INSTALL_DATA} ${FILESDIR}/${PORTNAME}.syslog ${STAGEDIR}${PREFIX}/etc/syslog.d/${PORTNAME}.conf
${INSTALL_DATA} ${FILESDIR}/${PORTNAME}.newsyslog ${STAGEDIR}${PREFIX}/etc/newsyslog.conf.d/${PORTNAME}.conf
.include <bsd.port.mk>