Changeset View
Standalone View
devel/py-mock/Makefile
# Created by: jessekempf@gmail.com | # Created by: jessekempf@gmail.com | ||||
# $FreeBSD$ | # $FreeBSD$ | ||||
PORTNAME= mock | PORTNAME= mock | ||||
PORTVERSION= 2.0.0 | PORTVERSION= 3.0.5 | ||||
CATEGORIES= devel python | CATEGORIES= devel python | ||||
MASTER_SITES= CHEESESHOP | |||||
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} | PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} | ||||
MAINTAINER= jessekempf@gmail.com | MAINTAINER= jessekempf@gmail.com | ||||
COMMENT= Mock unit tests for Python | COMMENT= Mock unit tests for Python | ||||
LICENSE= BSD2CLAUSE | LICENSE= BSD2CLAUSE | ||||
LICENSE_FILE= ${WRKSRC}/LICENSE.txt | LICENSE_FILE= ${WRKSRC}/LICENSE.txt | ||||
BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pbr>=1.3:devel/py-pbr@${PY_FLAVOR} \ | BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}six>=1.9:devel/py-six@${PY_FLAVOR} | ||||
bdrewery: Are these versions still accurate? | |||||
Done Inline Actionspbr's no longer needed, but six is still needed. The underlying code doesn't specify a specific six package version -- it just requires one to be installed. ngie: pbr's no longer needed, but six is still needed. The underlying code doesn't specify a specific… | |||||
${PYTHON_PKGNAMEPREFIX}six>=1.9:devel/py-six@${PY_FLAVOR} | TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pytest>0:devel/py-pytest@${PY_FLAVOR} \ | ||||
RUN_DEPENDS:= ${BUILD_DEPENDS} | ${PYTHON_PKGNAMEPREFIX}tox>0:devel/py-tox@${PY_FLAVOR} | ||||
Done Inline ActionsI think I was a bit hasty removing this line. Yes, six is needed for runtime use of the mock library. ngie: I think I was a bit hasty removing this line. Yes, six is needed for runtime use of the mock… | |||||
TESTS_DEPENDS= ${PYTHON_PKGNAMEPREFIX}tox>0:devel/py-tox@${PY_FLAVOR} | |||||
NO_ARCH= yes | |||||
USES= python | USES= python | ||||
USE_PYTHON= autoplist concurrent distutils | USE_PYTHON= autoplist concurrent distutils | ||||
NO_ARCH= yes | |||||
USE_GITHUB= yes | |||||
GH_ACCOUNT= testing-cabal | |||||
GH_PROJECT= mock | |||||
GH_TAGNAME= e0180b98d0e07e895a3f699b7e9afcac4716fc03 | |||||
Done Inline ActionsIs this line necessary? IMHO it only complicates future updating, slightly. What do I miss? Vladimir.Chukharev_gmail.com: Is this line necessary? IMHO it only complicates future updating, slightly. What do I miss? | |||||
Done Inline ActionsNeither GH_PROJECT now GH_TAGNAME should be needed here. I see a 3.0.5 tag. I think it should just work. bdrewery: Neither `GH_PROJECT` now `GH_TAGNAME` should be needed here. I see a 3.0.5 tag. I think it… | |||||
Done Inline Actions@bdrewery: could you please confirm that the above change is what you requested? ngie: @bdrewery: could you please confirm that the above change is what you requested? | |||||
Done Inline ActionsNot exactly, I believe. You can completely delete those two lines. You assign the same values which they get by default. I tested your patch without those lines for py36 flavor: 'port test', portmaster, poudriere, 'make test' - all ran OK. Vladimir.Chukharev_gmail.com: Not exactly, I believe. You can completely delete those two lines. You assign the same values… | |||||
Done Inline Actions@Vladimir.Chukharev_gmail.com: I appreciate the additional explanation (the previous reason wasn't gelling with me for some reason). I just updated the diff with your and @bdrewery's recommended change. ngie: @Vladimir.Chukharev_gmail.com: I appreciate the additional explanation (the previous reason… | |||||
.include <bsd.port.pre.mk> | .include <bsd.port.pre.mk> | ||||
.if ${PYTHON_REL} < 3300 | .if ${PYTHON_REL} < 3300 | ||||
RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}funcsigs>=0:devel/py-funcsigs@${PY_FLAVOR} | RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}funcsigs>=0:devel/py-funcsigs@${PY_FLAVOR} | ||||
.endif | .endif | ||||
do-test: | do-test: | ||||
@cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test | @cd ${WRKSRC} && pytest | ||||
.include <bsd.port.post.mk> | .include <bsd.port.post.mk> |
Are these versions still accurate?