Changeset View
Standalone View
x11-themes/materia-gtk-theme/Makefile
- This file was added.
| Property | Old Value | New Value |
|---|---|---|
| svn:eol-style | null | native \ No newline at end of property |
| svn:keywords | null | FreeBSD=%H \ No newline at end of property |
| svn:mime-type | null | text/plain \ No newline at end of property |
| # $FreeBSD$ | |||||
| PORTNAME= materia-gtk-theme | |||||
| DISTVERSIONPREFIX= v | |||||
| DISTVERSION= 20190201 | |||||
| CATEGORIES= x11-themes | |||||
| MAINTAINER= tagattie@yandex.com | |||||
| COMMENT= Material Design theme for GNOME/GTK+ based desktop environments | |||||
| LICENSE= GPLv2 | |||||
| LICENSE_FILE= ${WRKSRC}/COPYING | |||||
| BUILD_DEPENDS= bash:shells/bash | |||||
| RUN_DEPENDS= gtk-murrine-engine>0:x11-themes/gtk-murrine-engine \ | |||||
| gnome-themes-extra>0:x11-themes/gnome-themes-extra | |||||
| USES= shebangfix | |||||
| USE_GITHUB= yes | |||||
| GH_ACCOUNT= nana-4 | |||||
| GH_PROJECT= materia-theme | |||||
tcberner: ^ why not use that as the portname? | |||||
Done Inline ActionsThere is a matching Materia theme for KDE. rigoletto: There is a matching Materia theme for KDE. | |||||
Not Done Inline ActionsI wanted to make it clear that this port is GTK/Gnome theme because there is a materia theme for KDE as well. But I'm indifferent. materia-theme is fine with me. tagattie_yandex.com: I wanted to make it clear that this port is GTK/Gnome theme because there is a materia theme… | |||||
| NO_ARCH= yes | |||||
| NO_BUILD= yes | |||||
| PORTDOCS= COPYING README.md | |||||
| SHEBANG_FILES= install.sh | |||||
| OPTIONS_DEFINE= DOCS GNOMESHELL | |||||
| OPTIONS_DEFAULT= GNOMESHELL | |||||
| OPTIONS_SUB= yes | |||||
Done Inline ActionsIs COPYING necessary here? The license file is installed in "licenses" directory as well. tagattie_yandex.com: Is COPYING necessary here? The license file is installed in "licenses" directory as well. | |||||
Done Inline ActionsYes. There is no "licenses" directory. If upstream doesn't do it automatically at the install time that will not be in the ${DOCSDIR} if the port doesn't take care of it. :-) rigoletto: Yes. There is no "licenses" directory. If upstream doesn't do it automatically at the install… | |||||
Done Inline Actions^ why += ? tcberner: ^ why += ? | |||||
Done Inline ActionsThere is another was PORTDOCS in the GNOMESHELL OPTION. rigoletto: There is another was PORTDOCS in the GNOMESHELL OPTION. | |||||
| # the install script needs gnome-shell to determine its | |||||
| # version, but not all gtk themes users are Gnome users, | |||||
| # and keeping gnome-shell as standard build time dependency | |||||
| # would force non-Gnome users to build 110+ gnome ports just | |||||
| # to get the theme. | |||||
| GNOMESHELL_DESC= Add Gnome-Shell theme version | |||||
Done Inline Actions^ there should be some toggle for that for the build system to turn it on and off -- which kind of contradicts NO_BUILD -- why do you need it present? tcberner: ^ there should be some toggle for that for the build system to turn it on and off -- which kind… | |||||
Done Inline ActionsGood point! I was sure I've saw on the install file it would detect the gnome-shell presence on-the-fly to add or not the gnome-shell theme; however testing it now I see it is added anyway. So if that was true no-gnome user would need to build half gnome just to get one gtk theme. ^^ rigoletto: Good point! I was sure I've saw on the install file it would detect the gnome-shell presence on… | |||||
| GNOMESHELL_BUILD_DEPENDS= gnome-shell:x11/gnome-shell | |||||
| #GNOMESHELL_PORTDOCS= gnome-shell.README.md | |||||
| .include <bsd.port.options.mk> | |||||
Done Inline ActionsPORTDOCS= --> PORTDOCS+= ? tagattie_yandex.com: PORTDOCS= --> PORTDOCS+= ? | |||||
Done Inline ActionsThat is in the previous/general one. ^^ rigoletto: That is in the previous/general one. ^^ | |||||
| .if ${PORT_OPTIONS:MGNOMESHELL} | |||||
Done Inline ActionsGNOMESHELL_PORTDOCS=.... mat: ```
GNOMESHELL_PORTDOCS=....
``` | |||||
| PORTDOCS+= gnome-shell.README.md | |||||
| .endif | |||||
Done Inline ActionsShould this be ${STAGEDIR}${PREFIX}/share/themes ? tagattie_yandex.com: Should this be ${STAGEDIR}${PREFIX}/share/themes ? | |||||
Done Inline ActionsYes, thank you. rigoletto: Yes, thank you. | |||||
| do-install: | |||||
| ${MKDIR} ${STAGEDIR}${PREFIX}/share/themes | |||||
| ${WRKSRC}/install.sh --dest ${STAGEDIR}${PREFIX}/share/themes | |||||
| post-install: | |||||
Done Inline ActionsDon't use both do- and post- for the same stage, put everything in do-install. mat: Don't use both do- and post- for the same stage, put everything in do-install. | |||||
| ${MV} ${WRKSRC}/src/gnome-shell/README.md \ | |||||
| ${WRKSRC}/gnome-shell.README.md | |||||
Done Inline ActionsPORTDOCS contains files, why use COPYTREE_SHARE and not INSTALL_DATA? mat: `PORTDOCS` contains files, why use `COPYTREE_SHARE` and not `INSTALL_DATA`? | |||||
| ${RM} ${STAGEDIR}${PREFIX}/share/themes/*/COPYING | |||||
| ${RM} ${STAGEDIR}${PREFIX}/share/themes/*/gnome-shell/README.md | |||||
Done Inline ActionsRemoving top-level README.md's seems unnecessary since they are not installed in each theme directory. tagattie_yandex.com: Removing top-level README.md's seems unnecessary since they are not installed in each theme… | |||||
Done Inline ActionsYes, they are. I got tons of them after running make makeplist. ^^ rigoletto: Yes, they are. I got tons of them after running `make makeplist`. ^^ | |||||
| post-install-DOCS-on: | |||||
| ${MKDIR} ${STAGEDIR}${DOCSDIR} | |||||
| (cd ${WRKSRC} && \ | |||||
| ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR}) | |||||
| post-install-GNOMESHELL-off: | |||||
| ${RM} -R ${STAGEDIR}${PREFIX}/share/themes/*/gnome-shell | |||||
| .include <bsd.port.mk> | |||||
^ why not use that as the portname?