Changeset View
Standalone View
multimedia/gxine/Makefile
| # Created by: Grigori Goronzy <greg@chown.ath.cx> | # Created by: Grigori Goronzy <greg@chown.ath.cx> | ||||
| # $FreeBSD$ | # $FreeBSD$ | ||||
| PORTNAME= gxine | PORTNAME= gxine | ||||
| PORTVERSION= 0.5.910 | PORTVERSION= 0.5.910 | ||||
| PORTREVISION= 1 | PORTREVISION= 2 | ||||
| CATEGORIES= multimedia | CATEGORIES= multimedia | ||||
| MASTER_SITES= SF/xine/${PORTNAME}/${PORTVERSION} | MASTER_SITES= SF/xine/${PORTNAME}/${PORTVERSION} | ||||
| MAINTAINER= ports@FreeBSD.org | MAINTAINER= ports@FreeBSD.org | ||||
| COMMENT= Alternative GUI for the Xine media player | COMMENT= Alternative GUI for the Xine media player | ||||
| LICENSE= GPLv2 | LICENSE= GPLv2 | ||||
| LICENSE_FILES= ${WRKSRC}/COPYING | |||||
tobik: LICENSE_FILE (no S at the end) | |||||
| LIB_DEPENDS= libnspr4.so:devel/nspr \ | LIB_DEPENDS= libnspr4.so:devel/nspr \ | ||||
| libmozjs185.so:lang/spidermonkey185 \ | libmozjs185.so:lang/spidermonkey185 \ | ||||
| libxine.so:multimedia/libxine | libxine.so:multimedia/libxine | ||||
| USES= desktop-file-utils gettext gmake libtool pathfix pkgconfig tar:xz | USES= desktop-file-utils gmake gnome libtool pathfix pkgconfig tar:xz | ||||
| USE_GNOME= gtk30 | USE_GNOME= gtk30 | ||||
| GNU_CONFIGURE= yes | GNU_CONFIGURE= yes | ||||
| CONFIGURE_ARGS= --without-hal --with-libintl-prefix=${LOCALBASE} --with-gtk3 | CONFIGURE_ARGS= --without-hal --with-libintl-prefix=${LOCALBASE} --with-gtk3 | ||||
| LLD_UNSAFE= yes | |||||
| INSTALLS_ICONS= yes | INSTALLS_ICONS= yes | ||||
| CFLAGS+= -fPIC | |||||
matUnsubmitted Done Inline ActionsThis is probably a bad idea. mat: This is probably a bad idea. | |||||
tobikUnsubmitted Not Done Inline ActionsI feel like this is a problem that must be fixed in libxine and not worked around in every consumer. I don't understand why compiling gxine with -fPIC fixes linking to libxine with lld. tobik: I feel like this is a problem that must be fixed in libxine and not worked around in every… | |||||
ndowens_yahoo.comAuthorUnsubmitted Not Done Inline ActionsEd Maste replied to what I figured out that fPIC works around linker issue LLDunsafe didn’t work nor adding the ldflags Ed said is medium ndowens_yahoo.com: Ed Maste replied to what I figured out that fPIC works around linker issue
@tobik @mat
https… | |||||
tobikUnsubmitted Done Inline Actions
? Of course LLD_UNSAFE works here or we wouldn't have been able to build gxine on 12.0/amd64 at all previously. tobik: > LLDunsafe didn’t work
?
Of course LLD_UNSAFE works here or we wouldn't have been able to… | |||||
ndowens_yahoo.comAuthorUnsubmitted Done Inline ActionsRetying but I do believe I was getting linker issues with it ndowens_yahoo.com: Retying but I do believe I was getting linker issues with it | |||||
| CPPFLAGS+= -I${LOCALBASE}/include | CPPFLAGS+= -I${LOCALBASE}/include | ||||
| LDFLAGS+= -L${LOCALBASE}/lib -lm | LDFLAGS+= -L${LOCALBASE}/lib -lm | ||||
matUnsubmitted Done Inline ActionsMost of this would be USES=localbase mat: Most of this would be `USES=localbase` | |||||
ndowens_yahoo.comAuthorUnsubmitted Not Done Inline ActionsWas thinking about removing before posting here but didn’t know what -1m was for ndowens_yahoo.com: Was thinking about removing before posting here but didn’t know what -1m was for | |||||
tobikUnsubmitted Done Inline ActionsI don't think -lm is needed anymore. tobik: I don't think `-lm` is needed anymore. | |||||
| OPTIONS_DEFINE= GNOME LIRC WEBPLUGIN | OPTIONS_DEFINE= GNOME NLS LIRC WEBPLUGIN | ||||
| OPTIONS_SUB= yes | OPTIONS_SUB= yes | ||||
| GNOME_BUILD_DEPENDS= gnome-screensaver:x11/gnome-screensaver | |||||
| GNOME_LIB_DEPENDS= libdbus-glib-1.so:devel/dbus-glib | GNOME_LIB_DEPENDS= libdbus-glib-1.so:devel/dbus-glib | ||||
| GNOME_RUN_DEPENDS= gnome-screensaver:x11/gnome-screensaver | |||||
| GNOME_CONFIGURE_ON= --with-dbus | GNOME_CONFIGURE_ON= --with-dbus | ||||
| GNOME_CONFIGURE_OFF= --disable-integration-wizard --without-dbus | GNOME_CONFIGURE_OFF= --disable-integration-wizard --without-dbus | ||||
matUnsubmitted Done Inline ActionsPart of this should be: GNOME_CONFIGURE_WITH= dbus mat: Part of this should be:
```
GNOME_CONFIGURE_WITH= dbus
``` | |||||
tobikUnsubmitted Done Inline ActionsI am wondering if this does anything without GNOME screensaver running or if it is useless without it? --without-dbus disable dbus support (for GNOME screensaver) tobik: I am wondering if this does anything without GNOME screensaver running or if it is useless… | |||||
ndowens_yahoo.comAuthorUnsubmitted Done Inline ActionsI have no idea myself. I don’t use gnome and I don’t understand how a media player would even need screensaver dep. IIRC when I use to use gnome stuff I felt as gnome apps relied on dbus, but I could be wrong ndowens_yahoo.com: I have no idea myself. I don’t use gnome and I don’t understand how a media player would even… | |||||
tobikUnsubmitted Done Inline ActionsI say remove it in that case. The option has been broken for 4 years (when gnome-screensaver was removed) and nobody has complained so I doubt anybody cares about it. When you remove it make sure to append --disable-integration-wizard --without-dbus to CONFIGURE_ARGS in lieu of GNOME_CONFIGURE_OFF. tobik: I say remove it in that case. The option has been broken for 4 years (when gnome-screensaver… | |||||
| LIRC_LIB_DEPENDS= liblirc_client.so:comms/lirc | LIRC_LIB_DEPENDS= liblirc_client.so:comms/lirc | ||||
| LIRC_CONFIGURE_ON= --enable-lirc | LIRC_CONFIGURE_ENABLE= lirc | ||||
| LIRC_CONFIGURE_OFF= --disable-lirc | NLS_CONFIGURE_ENABLE= nls | ||||
| NLS_USES= gettext | |||||
| WEBPLUGIN_DESC= Build and/or install Web browser plugins | WEBPLUGIN_DESC= Build and/or install Web browser plugins | ||||
matUnsubmitted Done Inline ActionsDESCs should happen earlier, See Chapter 15. Order of Variables in Port Makefiles. mat: DESCs should happen earlier, See [[ https://www.freebsd.org/doc/en/books/porters… | |||||
| WEBPLUGIN_USE= xorg=xaw | WEBPLUGIN_USE= xorg=xaw | ||||
| WEBPLUGIN_USES= webplugin:native | WEBPLUGIN_USES= webplugin:native | ||||
| WEBPLUGIN_CONFIGURE_OFF= --without-browser-plugin | WEBPLUGIN_CONFIGURE_WITH= browser-plugin | ||||
| .include <bsd.port.options.mk> | |||||
| .if ${PORT_OPTIONS:MWEBPLUGIN} | |||||
| WEBPLUGIN_DIR= ${PREFIX}/lib/gxine | WEBPLUGIN_DIR= ${PREFIX}/lib/gxine | ||||
| WEBPLUGIN_FILES=gxineplugin.so | WEBPLUGIN_FILES= gxineplugin.so | ||||
| .endif | |||||
| post-patch: | post-patch: | ||||
| @${REINPLACE_CMD} -e \ | @${REINPLACE_CMD} -e \ | ||||
| '/CFLAGS/s|-I/usr/local/include|| ; \ | '/CFLAGS/s|-I/usr/local/include|| ; \ | ||||
| /CFLAGS/s|-L/usr/local/lib|| ; \ | /CFLAGS/s|-L/usr/local/lib|| ; \ | ||||
| /CPPFLAGS/s|-I/usr/local/include|| ; \ | /CPPFLAGS/s|-I/usr/local/include|| ; \ | ||||
| s|XINE_LIST=.*|XINE_LIST=|' ${WRKSRC}/configure | s|XINE_LIST=.*|XINE_LIST=|' ${WRKSRC}/configure | ||||
| @${REINPLACE_CMD} -e \ | @${REINPLACE_CMD} -e \ | ||||
| 's|@MAKE_PNG_TRUE@|#|' ${WRKSRC}/pixmaps/Makefile.in | 's|@MAKE_PNG_TRUE@|#|' ${WRKSRC}/pixmaps/Makefile.in | ||||
| post-install: | post-install: | ||||
| ${CP} ${WRKSRC}/pixmaps/logo.mpv ${STAGEDIR}${PREFIX}/share/gxine | ${INSTALL_DATA} ${WRKSRC}/pixmaps/logo.mpv ${STAGEDIR}${DATADIR} | ||||
| .if ${PORT_OPTIONS:MWEBPLUGIN} | ${INSTALL_DATA} ${WRKSRC}/pixmaps/logo.jpg ${STAGEDIR}${DATADIR} | ||||
matUnsubmitted Done Inline ActionsYou could probably fold those two commands into one. mat: You could probably fold those two commands into one. | |||||
tobikUnsubmitted Done Inline Actionslogo.jpg is already being installed. No need to do it manually. gxine now uses logo.jpg since the libxine update, so logo.mpv is not needed anymore. Let's drop post-install completely. tobik: logo.jpg is already being installed. No need to do it manually. gxine now uses logo.jpg since… | |||||
| post-install-WEBPLUGIN-on: | |||||
| @${STRIP_CMD} ${STAGEDIR}${WEBPLUGIN_DIR}/${WEBPLUGIN_FILES} | @${STRIP_CMD} ${STAGEDIR}${WEBPLUGIN_DIR}/${WEBPLUGIN_FILES} | ||||
| .endif | |||||
| .include <bsd.port.mk> | .include <bsd.port.mk> | ||||
LICENSE_FILE (no S at the end)