Changeset View
Changeset View
Standalone View
Standalone View
sys/dev/amdsmb/amdsmb.c
Show First 20 Lines • Show All 119 Lines • ▼ Show 20 Lines | |||||
#define AMDSMB_ECINB(amdsmb, register) \ | #define AMDSMB_ECINB(amdsmb, register) \ | ||||
(bus_read_1(amdsmb->res, register)) | (bus_read_1(amdsmb->res, register)) | ||||
#define AMDSMB_ECOUTB(amdsmb, register, value) \ | #define AMDSMB_ECOUTB(amdsmb, register, value) \ | ||||
(bus_write_1(amdsmb->res, register, value)) | (bus_write_1(amdsmb->res, register, value)) | ||||
static int amdsmb_detach(device_t dev); | static int amdsmb_detach(device_t dev); | ||||
static struct amdsmb_dev { | |||||
uint16_t vendorid; | |||||
uint16_t deviceid; | |||||
const char *description; | |||||
} amdsmb_devs[] = { | |||||
{ AMDSMB_VENDORID_AMD, AMDSMB_DEVICEID_AMD8111_SMB2, | |||||
"AMD-8111 SMBus 2.0 Controller" }, | |||||
}; | |||||
static int | static int | ||||
amdsmb_probe(device_t dev) | amdsmb_probe(device_t dev) | ||||
{ | { | ||||
const struct amdsmb_dev *asd; | |||||
u_int16_t vid; | u_int16_t vid; | ||||
u_int16_t did; | u_int16_t did; | ||||
size_t i; | |||||
vid = pci_get_vendor(dev); | vid = pci_get_vendor(dev); | ||||
did = pci_get_device(dev); | did = pci_get_device(dev); | ||||
if (vid == AMDSMB_VENDORID_AMD) { | if (vid == AMDSMB_VENDORID_AMD) { | ||||
switch(did) { | for (i=0; i < nitems(amdsmb_devs); i++) { | ||||
case AMDSMB_DEVICEID_AMD8111_SMB2: | asd = &amdsmb_devs[i]; | ||||
device_set_desc(dev, "AMD-8111 SMBus 2.0 Controller"); | if (asd->deviceid == did) { | ||||
chuck: style nit, space between key word (`if`) and open parenthesis. Also needed on either side of… | |||||
device_set_desc(dev, asd->description); | |||||
return (BUS_PROBE_DEFAULT); | return (BUS_PROBE_DEFAULT); | ||||
} | } | ||||
} | } | ||||
} | |||||
return (ENXIO); | return (ENXIO); | ||||
} | } | ||||
static int | static int | ||||
amdsmb_attach(device_t dev) | amdsmb_attach(device_t dev) | ||||
{ | { | ||||
struct amdsmb_softc *amdsmb_sc = device_get_softc(dev); | struct amdsmb_softc *amdsmb_sc = device_get_softc(dev); | ||||
▲ Show 20 Lines • Show All 421 Lines • ▼ Show 20 Lines | |||||
static driver_t amdsmb_driver = { | static driver_t amdsmb_driver = { | ||||
"amdsmb", | "amdsmb", | ||||
amdsmb_methods, | amdsmb_methods, | ||||
sizeof(struct amdsmb_softc), | sizeof(struct amdsmb_softc), | ||||
}; | }; | ||||
DRIVER_MODULE(amdsmb, pci, amdsmb_driver, amdsmb_devclass, 0, 0); | DRIVER_MODULE(amdsmb, pci, amdsmb_driver, amdsmb_devclass, 0, 0); | ||||
MODULE_PNP_INFO("U16:vendor;U16:device;D:#", pci, amdsmb, amdsmb_devs, | |||||
sizeof(amdsmb_devs[0]), nitems(amdsmb_devs)); | |||||
DRIVER_MODULE(smbus, amdsmb, smbus_driver, smbus_devclass, 0, 0); | DRIVER_MODULE(smbus, amdsmb, smbus_driver, smbus_devclass, 0, 0); | ||||
MODULE_DEPEND(amdsmb, pci, 1, 1, 1); | MODULE_DEPEND(amdsmb, pci, 1, 1, 1); | ||||
MODULE_DEPEND(amdsmb, smbus, SMBUS_MINVER, SMBUS_PREFVER, SMBUS_MAXVER); | MODULE_DEPEND(amdsmb, smbus, SMBUS_MINVER, SMBUS_PREFVER, SMBUS_MAXVER); | ||||
MODULE_VERSION(amdsmb, 1); | MODULE_VERSION(amdsmb, 1); |
style nit, space between key word (if) and open parenthesis. Also needed on either side of comparator above (i.e. i < nitems(amdsmb_devs). Please fix here and check all other code modifications for this type of error.