Changeset View
Standalone View
net-im/psi/Makefile
# Created by: Jonathan Chen <jonc@chen.org.nz> | # Created by: Jonathan Chen <jonc@chen.org.nz> | ||||
# $FreeBSD$ | # $FreeBSD$ | ||||
PORTNAME= psi | PORTNAME= psi | ||||
PORTVERSION= 0.15 | DISTVERSION= 1.3 | ||||
mat: Please use DISTVERSION | |||||
Not Done Inline ActionsSorry, I don't get it. Why I need DISTVERSION here? arrowd: Sorry, I don't get it. Why I need `DISTVERSION` here? | |||||
Not Done Inline ActionsTo use instead of PORTVERSION. See 5.2.2. Versions, DISTVERSION or PORTVERSION mat: To use instead of PORTVERSION. See [[ https://www.freebsd.org/doc/en/books/porters… | |||||
Not Done Inline ActionsThere is no problem with versioning: $ pkg version -t 0.15 1.3 < I don't understand why we need DISTVERSION here, could you point it out? lwhsu: There is no problem with versioning:
```
$ pkg version -t 0.15 1.3
<
```
I don't understand why… | |||||
Not Done Inline ActionsIt was @mat suggestion, I didn't get it too, tbh. arrowd: It was @mat suggestion, I didn't get it too, tbh. | |||||
PORTREVISION= 5 | |||||
CATEGORIES= net-im | CATEGORIES= net-im | ||||
MASTER_SITES= SF/${PORTNAME}/Psi/${PORTVERSION} | MASTER_SITES= SF/${PORTNAME}/Psi/${PORTVERSION} | ||||
Done Inline ActionsNo need to add a / here. mat: No need to add a / here. | |||||
MAINTAINER= ports@FreeBSD.org | MAINTAINER= ports@FreeBSD.org | ||||
COMMENT= Qt 4 based Jabber client | COMMENT= Qt based Jabber client | ||||
LIB_DEPENDS= libqca.so:devel/qca@qt4 \ | LICENSE= GPLv2 | ||||
libminizip.so:archivers/minizip | |||||
Done Inline Actions^qca has been flavores, this should now be qca@qt5 tcberner: ^qca has been flavores, this should now be qca@qt5 | |||||
Done Inline Actions^ after thought: it also does not hurt in my opinion to sort the LIIB_DEPENDS alphabetically. -- same for the USES= tcberner: ^ after thought: it also does not hurt in my opinion to sort the LIIB_DEPENDS alphabetically. | |||||
HAS_CONFIGURE= yes | LIB_DEPENDS= libidn.so:dns/libidn \ | ||||
QT_NONSTANDARD= yes | libminizip.so:archivers/minizip \ | ||||
USES= pkgconfig tar:bzip2 | libqca-qt5.so:devel/qca@qt5 | ||||
USE_QT4= gui network xml imageformats_run \ | |||||
qmake_build moc_build rcc_build uic_build | |||||
USE_XORG= xscrnsaver | |||||
CONFIGURE_ARGS= --prefix=${PREFIX} --qtdir=${LOCALBASE} \ | USES= cmake desktop-file-utils pkgconfig tar:xz | ||||
--disable-growl --verbose | |||||
CONFIGURE_ENV= QMAKE_ARGS='${QMAKE_ARGS}' | |||||
DESTDIRNAME= INSTALL_ROOT | |||||
OPTIONS_DEFINE= ASPELL ENCHANT DBUS DEBUG | CMAKE_ARGS= -DIDN_LIBRARY=${LOCALBASE}/lib/libidn.so \ | ||||
OPTIONS_DEFAULT= ENCHANT DBUS | -DIDN_INCLUDE_DIR=${LOCALBASE}/include \ | ||||
OPTIONS_SUB= yes # DEBUG | -DUSE_WEBENGINE:BOOL=FALSE | ||||
DEBUG_CONFIGURE_ON= --debug | USE_QT5= buildtools_build concurrent core dbus gui imageformats_run \ | ||||
tcbernerUnsubmitted Not Done Inline Actionsas mentioned above, I would not mix the _build and _run only dependencies into the others. tcberner: as mentioned above, I would not mix the _build and _run only dependencies into the others. | |||||
DEBUG_CONFIGURE_OFF= --release --no-separate-debug-info | multimedia network qmake_build svg webkit widgets x11extras xml | ||||
Done Inline Actions=0 is probably wrong, it should probably be :BOOL=false mat: `=0` is probably wrong, it should probably be `:BOOL=false` | |||||
Not Done Inline ActionsIt was OK, actually, CMake treats 0, FALSE and NO as FALSE. arrowd: It was OK, actually, CMake treats `0`, `FALSE` and `NO` as `FALSE`. | |||||
Not Done Inline ActionsThe important bit is to always set a type for variables, :BOOL, :STRING... so that cmake does not have to guess from the content what you really meant. mat: The important bit is to always set a type for variables, `:BOOL`, `:STRING`... so that cmake… | |||||
Not Done Inline ActionsCMake uses type information only in cmake-gui to display right widget. It has no effect on code semantics. arrowd: CMake uses type information only in `cmake-gui` to display right widget. It has no effect on… | |||||
USE_XORG= ice sm x11 xcb xext xscrnsaver | |||||
DBUS_USE= QT4=dbus | OPTIONS_RADIO= SPELLCHECKER | ||||
DBUS_CONFIGURE_OFF= --disable-qdbus | OPTIONS_RADIO_SPELLCHECKER= HUNSPELL ENCHANT | ||||
OPTIONS_DEFAULT= ENCHANT | |||||
ASPELL_DESC= Use aspell for spell checking | HUNSPELL_DESC= Use hunspell for spell checking | ||||
ASPELL_LIB_DEPENDS= libaspell.so:textproc/aspell | HUNSPELL_LIB_DEPENDS= libhunspell-1.6.so:textproc/hunspell | ||||
ASPELL_CONFIGURE_ON= --with-aspell-inc=${LOCALBASE}/include \ | HUNSPELL_CMAKE_BOOL= USE_HUNSPELL | ||||
--with-aspell-lib=${LOCALBASE}/lib | |||||
ASPELL_CONFIGURE_OFF= --disable-aspell | |||||
Done Inline ActionsWhat exactly is being debugged here? mat: What exactly is being debugged here? | |||||
Not Done Inline ActionsNothing, forgot to remove. arrowd: Nothing, forgot to remove. | |||||
ENCHANT_DESC= Use Enchant for spell checking | ENCHANT_DESC= Use Enchant for spell checking | ||||
ENCHANT_LIB_DEPENDS= libenchant.so:textproc/enchant | ENCHANT_LIB_DEPENDS= libenchant.so:textproc/enchant | ||||
Done Inline Actions^ sort these by kind alphabetically -- I think it makes it easier to add/look for already present dependencies: USE_QT5= concurrentcore dbus gui multimedia network svg webkit widgets x11extras xml \ buildtools_build qmake_build \ imageformats_run [the last line break I can live without ^^ ] tcberner: ^ sort these by kind alphabetically -- I think it makes it easier to add/look for already… | |||||
ENCHANT_CONFIGURE_OFF= --disable-enchant | ENCHANT_CMAKE_BOOL= USE_ENCHANT | ||||
post-configure: | |||||
# Reorder paths to always include internal socks.h (PR: 192270) | |||||
${REINPLACE_CMD} -e '/^INCPATH/s,-I\.,-I\. -Icutestuff,' \ | |||||
${WRKSRC}/iris/src/irisnet/noncore/Makefile | |||||
${REINPLACE_CMD} -e '/^INCPATH/s,-I\.,-I\. -I../irisnet/noncore/cutestuff,' \ | |||||
${WRKSRC}/iris/src/xmpp/Makefile | |||||
Done Inline ActionsPlease use the CMAKE_BOOL helper. mat: Please use the CMAKE_BOOL helper. | |||||
Done Inline Actions^sort these alphabetically tcberner: ^sort these alphabetically | |||||
.include <bsd.port.mk> | .include <bsd.port.mk> |
Please use DISTVERSION