Changeset View
Standalone View
multimedia/mpv/Makefile
Context not available. | |||||
PORTNAME= mpv | PORTNAME= mpv | ||||
PORTVERSION= 0.25.0 | PORTVERSION= 0.25.0 | ||||
DISTVERSIONPREFIX= v | |||||
PORTREVISION= 1 | PORTREVISION= 1 | ||||
DISTVERSIONPREFIX= v | |||||
PORTEPOCH= 1 | PORTEPOCH= 1 | ||||
CATEGORIES= multimedia audio | CATEGORIES= multimedia audio | ||||
Context not available. | |||||
pkgconfig python:build waf | pkgconfig python:build waf | ||||
USE_LDCONFIG= yes | USE_LDCONFIG= yes | ||||
CONFIGURE_ENV= BIN_PYTHON=${PYTHON_CMD} | CONFIGURE_ENV= BIN_PYTHON="${PYTHON_CMD}" | ||||
CONFIGURE_ARGS= --docdir=${EXAMPLESDIR} \ | CONFIGURE_ARGS= --docdir="${EXAMPLESDIR}" \ | ||||
--htmldir=${DOCSDIR}/html \ | --htmldir="${DOCSDIR}/html" \ | ||||
--mandir=${MANPREFIX}/man \ | --mandir="${MANPREFIX}/man" \ | ||||
--disable-debug-build \ | --disable-debug-build \ | ||||
--disable-d3d-hwaccel \ | --disable-d3d-hwaccel \ | ||||
--disable-optimize \ | --disable-optimize \ | ||||
Context not available. | |||||
--disable-wayland \ | --disable-wayland \ | ||||
--enable-libmpv-shared | --enable-libmpv-shared | ||||
OPTIONS_DEFINE= ASS DOCS LCMS2 LIBARCHIVE LUAJIT MANPAGES UCHARDET ZSH | OPTIONS_DEFINE= ASS DOCS LCMS2 LIBARCHIVE LUAJIT MANPAGES TEST UCHARDET ZSH | ||||
OPTIONS_DEFAULT= ASS DVDREAD DVDNAV LIBARCHIVE MANPAGES OPENGL UCHARDET \ | OPTIONS_DEFAULT= ASS DVDREAD DVDNAV LIBARCHIVE MANPAGES OPENGL UCHARDET \ | ||||
V4L VAAPI VDPAU X11 YTDL ZSH | V4L VAAPI VDPAU X11 YTDL ZSH | ||||
OPTIONS_GROUP= IN VO AO | OPTIONS_GROUP= IN VO AO | ||||
Context not available. | |||||
DVDNAV_DESC= DVD menu navigation | DVDNAV_DESC= DVD menu navigation | ||||
LIBARCHIVE_DESC= Enable libarchive support | LIBARCHIVE_DESC= Enable libarchive support | ||||
jbeich: Maybe rename LIBARCHIVE to ARCHIVE and use _DESC from Mk/bsd.options.desc.mk. | |||||
LUAJIT_DESC= Use LuaJIT instead of Lua scripting language support | LUAJIT_DESC= Use LuaJIT instead of Lua scripting language support | ||||
TEST_DESC= Enable test suite | |||||
Done Inline ActionsDoesn't explain more than TEST_DESC in Mk/bsd.options.desc.mk. Maybe drop. jbeich: Doesn't explain more than TEST_DESC in Mk/bsd.options.desc.mk. Maybe drop. | |||||
UCHARDET_DESC= Guess subtitle encoding via uchardet | |||||
YTDL_DESC= Install youtube-dl | YTDL_DESC= Install youtube-dl | ||||
UCHARDET_DESC= Guess subtitle encoding via uchardet | |||||
IN_DESC= Input | IN_DESC= Input | ||||
VO_DESC= Video Output | VO_DESC= Video Output | ||||
AO_DESC= Audio Output | AO_DESC= Audio Output | ||||
Context not available. | |||||
SMB_USES= samba:lib | SMB_USES= samba:lib | ||||
SMB_CONFIGURE_OFF= --disable-libsmbclient | SMB_CONFIGURE_OFF= --disable-libsmbclient | ||||
TEST_LIB_DEPENDS= libcmocka.so:sysutils/cmocka | |||||
TEST_CONFIGURE_ENV= PKG_CONFIG_PATH="${LOCALBASE}/lib/pkgconfig" | |||||
TEST_CONFIGURE_ON= --enable-test | |||||
Done Inline ActionsUse TEST_BUILD_DEPENDS = cmocka>0:sysutils/cmocka as you don't install test binaries. jbeich: Use `TEST_BUILD_DEPENDS = cmocka>0:sysutils/cmocka` as you don't install test binaries. | |||||
Not Done Inline ActionsNo, it needs libcmocka.so to run unittest. Furthermore sysutils/cmocka doesn't include cmocka binary. cpm: No, it needs `libcmocka.so` to run unittest. Furthermore `sysutils/cmocka` doesn't include… | |||||
Not Done Inline Actions
jbeich: - Why `mpv` (not the unittest) links against `libcmocka.so` without using any of its symbols? | |||||
Not Done Inline ActionsWhat is this for? jbeich: What is this for? | |||||
Not Done Inline ActionsMpv is unable to find libcmocka.pc in the default PKG_CONFIG_PATH. cpm: Mpv is unable to find `libcmocka.pc` in the default PKG_CONFIG_PATH. | |||||
Done Inline ActionsrP442784 moved libcmocka.pc under libdata/pkgconfig. Maybe upgrade. Can you reproduce via poudriere + TEST=on? jbeich: rP442784 moved `libcmocka.pc` under `libdata/pkgconfig`. Maybe upgrade. Can you reproduce via… | |||||
Not Done Inline ActionsYou're right! Rebuilding cmocka port did the trick. cpm: You're right! Rebuilding cmocka port did the trick. | |||||
UCHARDET_LIB_DEPENDS= libuchardet.so:textproc/uchardet | UCHARDET_LIB_DEPENDS= libuchardet.so:textproc/uchardet | ||||
UCHARDET_CONFIGURE_OFF= --disable-uchardet | UCHARDET_CONFIGURE_OFF= --disable-uchardet | ||||
Context not available. | |||||
ZSH_USES= perl5 | ZSH_USES= perl5 | ||||
ZSH_USE= PERL5=build | ZSH_USE= PERL5=build | ||||
ZSH_CONFIGURE_ENV= BIN_PERL=${PERL} | ZSH_CONFIGURE_ENV= BIN_PERL="${PERL}" | ||||
ZSH_CONFIGURE_ENABLE= zsh-comp | ZSH_CONFIGURE_ENABLE= zsh-comp | ||||
post-patch: | post-patch: | ||||
Context not available. | |||||
@${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/mpv | @${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/mpv | ||||
@${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libmpv.so | @${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libmpv.so | ||||
do-test-TEST-on: | |||||
.for test in chmap chmap_sel gl_video | |||||
@cd ${WRKSRC}/build/test && ./${test} | |||||
Done Inline ActionsGiven TEST is a non-default option and poudriere#355 still hasn't landed maybe also add the following to always run tests if enabled. By using TEST=on for every release/arch jail you have it may help catching regressions early on updates, assuming you have time to keep the tests green. pre-install-TEST-on: do-test-TEST-on jbeich: Given TEST is a non-default option and [poudriere#355](https://github. | |||||
.endfor | |||||
Not Done Inline Actions
jbeich: - Any reason for `cd`? Do you expect the tests to write/read something under current directory… | |||||
Not Done Inline ActionsWell, another way to run it might look like this .for test in ${TEST_UNITTESTFILES} ${WRKSRC}/build/tests/${test} .endfor cpm: Well, another way to run it might look like this
```
.for test in ${TEST_UNITTESTFILES}… | |||||
.include <bsd.port.mk> | .include <bsd.port.mk> | ||||
Context not available. |
Maybe rename LIBARCHIVE to ARCHIVE and use _DESC from Mk/bsd.options.desc.mk.