net/ifdepd: fix clang 13 warnings and non-static inline functions
Building net/ifdepd with clang and lld 13 results in a few warnings, and
a link error:
cc -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wall -Wnested-externs -Wpointer-arith -Winline -Wcast-qual -Wredundant-decls -c ifdepd.c -o ifdepd.o
ifdepd.c:420:4: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
free(d_ints); ^
ifdepd.c:418:2: note: previous statement is here
if (D) ^
ifdepd.c:434:4: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
free(s_ints); ^
ifdepd.c:432:2: note: previous statement is here
if (S) ^
2 warnings generated.
cc -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -Wall -Wnested-externs -Wpointer-arith -Winline -Wcast-qual -Wredundant-decls -o ifdepd ifdepd.o
ld: error: undefined symbol: cleanup
referenced by ifdepd.c
ifdepd.o:(main)referenced by ifdepd.c
ifdepd.o:(main)referenced by ifdepd.c
ifdepd.o:(main)referenced 1 more times
cc: error: linker command failed with exit code 1 (use -v to see invocation)
- Error code 1
The warnings about misleading indentation are indicating an actual bug,
which can be fixed by adding a few braces. The link error is because
ifdepd uses an inline function without either a static or an extern
specifier. Fix this by adding a static specifier.
Approved by: alex@hugo.bmg.gv.at (maintainer)
PR: 258512
MFH: 2021Q3