Page MenuHomeFreeBSD
Files F164912276

D57665.id.diff
No OneTemporary
Actions

D57665.id.diff
View Options

diff --git a/share/man/man9/socket.9 b/share/man/man9/socket.9
--- a/share/man/man9/socket.9
+++ b/share/man/man9/socket.9
@@ -24,7 +24,7 @@
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE.
.\"
-.Dd September 6, 2022
+.Dd July 1, 2026
.Dt SOCKET 9
.Os
.Sh NAME
@@ -146,6 +146,8 @@
.Ft int
.Fn sooptcopyin "struct sockopt *sopt" "void *buf" "size_t len" "size_t minlen"
.Ft int
+.Fn sooptcopyinptr "struct sockopt *sopt" "void *buf" "size_t len" "size_t minlen"
+.Ft int
.Fn sooptcopyout "struct sockopt *sopt" "const void *buf" "size_t len"
.Sh DESCRIPTION
The kernel
@@ -577,6 +579,15 @@
are useful for transferring
.Vt struct sockopt
data between user and kernel code.
+They do not preserve the provenance of pointers in copied objects
+.Pq see Xr memory_model 7 for further information .
+If the object to be copied contains pointers, the
+.Fn sooptcopyinptr
+function must be used to preserve the provenance of those pointers.
+There is no corresponding
+.Fn sooptcopyoutptr
+as the kernel does not typically return pointers to userspace objects
+and instead would update objects previously passed via sooptcopyinptr.
.Sh SEE ALSO
.Xr bind 2 ,
.Xr close 2 ,
diff --git a/sys/kern/uipc_socket.c b/sys/kern/uipc_socket.c
--- a/sys/kern/uipc_socket.c
+++ b/sys/kern/uipc_socket.c
@@ -3808,8 +3808,9 @@
* here, these functions are also called by the protocol-level pr_ctloutput()
* routines.
*/
-int
-sooptcopyin(struct sockopt *sopt, void *buf, size_t len, size_t minlen)
+static int
+_sooptcopyin(struct sockopt *sopt, void *buf, size_t len, size_t minlen,
+ bool copycaps)
{
size_t valsize;
@@ -3824,13 +3825,34 @@
if (valsize > len)
sopt->sopt_valsize = valsize = len;
- if (sopt->sopt_td != NULL)
- return (copyin(sopt->sopt_val, buf, valsize));
+ if (sopt->sopt_td != NULL) {
+ if (copycaps)
+ return (copyinptr(sopt->sopt_val, buf, valsize));
+ else
+ return (copyin(sopt->sopt_val, buf, valsize));
+ }
- memcpy(buf, sopt->sopt_val, valsize);
+ if (copycaps)
+ memcpy(buf, sopt->sopt_val, valsize);
+ else
+ memcpy_data(buf, sopt->sopt_val, valsize);
return (0);
}
+int
+sooptcopyin(struct sockopt *sopt, void *buf, size_t len, size_t minlen)
+{
+ return (_sooptcopyin(sopt, buf, len, minlen, false));
+}
+
+#ifdef __CHERI__
+int
+sooptcopyinptr(struct sockopt *sopt, void *buf, size_t len, size_t minlen)
+{
+ return (_sooptcopyin(sopt, buf, len, minlen, true));
+}
+#endif
+
/*
* Kernel version of setsockopt(2).
*
@@ -4118,7 +4140,7 @@
if (sopt->sopt_td != NULL)
error = copyout(buf, sopt->sopt_val, valsize);
else
- memcpy(sopt->sopt_val, buf, valsize);
+ memcpy_data(sopt->sopt_val, buf, valsize);
}
return (error);
}
diff --git a/sys/sys/sockopt.h b/sys/sys/sockopt.h
--- a/sys/sys/sockopt.h
+++ b/sys/sys/sockopt.h
@@ -59,6 +59,12 @@
int sogetopt(struct socket *so, struct sockopt *sopt);
int __result_use_check sooptcopyin(struct sockopt *sopt, void *buf, size_t len,
size_t minlen);
+#ifdef __CHERI__
+int __result_use_check sooptcopyinptr(struct sockopt *sopt, void *buf,
+ size_t len, size_t minlen);
+#else
+#define sooptcopyinptr sooptcopyin
+#endif
int __result_use_check sooptcopyout(struct sockopt *sopt, const void *buf,
size_t len);
int soopt_getm(struct sockopt *sopt, struct mbuf **mp);

File Metadata

Mime Type
text/plain
Expires
Wed, Aug 5, 6:44 PM (7 h, 21 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
36045948
Default Alt Text
D57665.id.diff (3 KB)

Event Timeline