D56809.id177200.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D56809.id177200.diff
View Options

	diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c
	--- a/sys/dev/acpica/acpi_spmc.c
	+++ b/sys/dev/acpica/acpi_spmc.c
	@@ -649,7 +649,9 @@
	static void
	acpi_spmc_check_constraints(struct acpi_spmc_softc *sc)
	{
	+#ifdef notyet
	bool violation = false;
	+#endif

	KASSERT(sc->constraints_populated, ("Constraints not populated"));
	for (size_t i = 0; i < sc->constraint_count; i++) {
	@@ -665,19 +667,24 @@
	if (ACPI_FAILURE(acpi_pwr_get_state(constraint->handle, &d_state)))
	continue;
	if (d_state < constraint->min_d_state) {
	- device_printf(sc->dev, "constraint for device %s"
	- " violated (minimum D-state required was %s, actual"
	- " D-state is %s), might fail to enter LPI state\n",
	+ device_printf(sc->dev, "Constraint for device %s"
	+ " violated (current D-state: %s, "
	+ "required minimum D-state: %s).\n"
	constraint->name,
	- acpi_d_state_to_str(constraint->min_d_state),
	- acpi_d_state_to_str(d_state));
	+ acpi_d_state_to_str(d_state),
	+ acpi_d_state_to_str(constraint->min_d_state));
	violation = true;
	}
	#endif
	}
	- if (!violation)
	+#ifdef notyet
	+ if (violation)
	+ device_printf(sc->dev, "Some constraints violated, "
	+ "might fail to enter a Low-Power Idle state\n");
	+ else
	device_printf(sc->dev,
	- "all device power constraints respected!\n");
	+ "All device power constraints respected!\n");
	+#endif
	}

	static void