D7333.id18799.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D7333.id18799.diff
View Options

	Index: sys/dev/hyperv/vmbus/vmbus_br.c
	===================================================================
	--- sys/dev/hyperv/vmbus/vmbus_br.c
	+++ sys/dev/hyperv/vmbus/vmbus_br.c
	@@ -209,9 +209,7 @@
	if (tbr->txbr_imask)
	return (FALSE);

	- /* XXX only compiler fence is needed */
	- /* Read memory barrier */
	- rmb();
	+ __compiler_membar();

	/*
	* This is the only case we need to signal when the
	@@ -308,15 +306,10 @@
	sizeof(save_windex));

	/*
	- * XXX only compiler fence is needed.
	- * Full memory barrier before upding the write index.
	- */
	- mb();
	-
	- /*
	* Update the write index _after_ the channel packet
	* is copied.
	*/
	+ __compiler_membar();
	tbr->txbr_windex = windex;

	mtx_unlock_spin(&tbr->txbr_lock);
	@@ -396,16 +389,9 @@
	rindex = VMBUS_BR_IDXINC(rindex, sizeof(uint64_t), br_dsize);

	/*
	- * XXX only compiler fence is needed.
	- * Make sure all reads are done before we update the read index since
	- * the writer may start writing to the read area once the read index
	- * is updated.
	- */
	- wmb();
	-
	- /*
	* Update the read index _after_ the channel packet is fetched.
	*/
	+ __compiler_membar();
	rbr->rxbr_rindex = rindex;

	mtx_unlock_spin(&rbr->rxbr_lock);