Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F156977077
D20485.id58162.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
6 KB
Referenced Files
None
Subscribers
None
D20485.id58162.diff
View Options
Index: sys/vm/memguard.c
===================================================================
--- sys/vm/memguard.c
+++ sys/vm/memguard.c
@@ -262,7 +262,7 @@
if (pa == 0)
panic("MemGuard detected double-free of %p", (void *)va);
p = PHYS_TO_VM_PAGE(pa);
- KASSERT(p->wire_count != 0 && p->queue == PQ_NONE,
+ KASSERT(vm_page_wired(p) && p->queue == PQ_NONE,
("MEMGUARD: Expected wired page %p in vtomgfifo!", p));
return (&p->plinks.memguard.p);
}
@@ -277,7 +277,7 @@
if (pa == 0)
panic("MemGuard detected double-free of %p", (void *)va);
p = PHYS_TO_VM_PAGE(pa);
- KASSERT(p->wire_count != 0 && p->queue == PQ_NONE,
+ KASSERT(vm_page_wired(p) && p->queue == PQ_NONE,
("MEMGUARD: Expected wired page %p in vtomgfifo!", p));
return (&p->plinks.memguard.v);
}
Index: sys/vm/swap_pager.c
===================================================================
--- sys/vm/swap_pager.c
+++ sys/vm/swap_pager.c
@@ -1679,7 +1679,7 @@
vm_page_dirty(m);
#ifdef INVARIANTS
vm_page_lock(m);
- if (m->wire_count == 0 && m->queue == PQ_NONE)
+ if (!vm_page_wired(m) && m->queue == PQ_NONE)
panic("page %p is neither wired nor queued", m);
vm_page_unlock(m);
#endif
Index: sys/vm/vm_fault.c
===================================================================
--- sys/vm/vm_fault.c
+++ sys/vm/vm_fault.c
@@ -1004,7 +1004,7 @@
*/
if (rv == VM_PAGER_ERROR || rv == VM_PAGER_BAD) {
vm_page_lock(fs.m);
- if (fs.m->wire_count == 0)
+ if (!vm_page_wired(fs.m))
vm_page_free(fs.m);
else
vm_page_xunbusy_maybelocked(fs.m);
@@ -1027,7 +1027,7 @@
*/
if (fs.object != fs.first_object) {
vm_page_lock(fs.m);
- if (fs.m->wire_count == 0)
+ if (!vm_page_wired(fs.m))
vm_page_free(fs.m);
else
vm_page_xunbusy_maybelocked(fs.m);
@@ -1805,7 +1805,7 @@
vm_page_wire(dst_m);
vm_page_unlock(dst_m);
} else {
- KASSERT(dst_m->wire_count > 0,
+ KASSERT(vm_page_wired(dst_m),
("dst_m %p is not wired", dst_m));
}
} else {
Index: sys/vm/vm_object.c
===================================================================
--- sys/vm/vm_object.c
+++ sys/vm/vm_object.c
@@ -720,7 +720,7 @@
*/
vm_page_change_lock(p, &mtx);
p->object = NULL;
- if (p->wire_count != 0)
+ if (vm_page_wired(p))
continue;
VM_CNT_INC(v_pfree);
vm_page_free(p);
@@ -1595,7 +1595,7 @@
vm_page_lock(p);
KASSERT(!pmap_page_is_mapped(p),
("freeing mapped page %p", p));
- if (p->wire_count == 0)
+ if (!vm_page_wired(p))
vm_page_free(p);
else
vm_page_remove(p);
@@ -1639,7 +1639,7 @@
vm_page_lock(p);
KASSERT(!pmap_page_is_mapped(p),
("freeing mapped page %p", p));
- if (p->wire_count == 0)
+ if (!vm_page_wired(p))
vm_page_free(p);
else
vm_page_remove(p);
@@ -1944,7 +1944,7 @@
VM_OBJECT_WLOCK(object);
goto again;
}
- if (p->wire_count != 0) {
+ if (vm_page_wired(p)) {
if ((options & OBJPR_NOTMAPPED) == 0 &&
object->ref_count != 0)
pmap_remove_all(p);
Index: sys/vm/vm_page.h
===================================================================
--- sys/vm/vm_page.h
+++ sys/vm/vm_page.h
@@ -822,5 +822,12 @@
return (m->hold_count > 0 || m->wire_count > 0);
}
+static inline bool
+vm_page_wired(vm_page_t m)
+{
+
+ return (m->wire_count > 0);
+}
+
#endif /* _KERNEL */
#endif /* !_VM_PAGE_ */
Index: sys/vm/vm_page.c
===================================================================
--- sys/vm/vm_page.c
+++ sys/vm/vm_page.c
@@ -2608,7 +2608,7 @@
error = ENOMEM;
goto unlock;
}
- KASSERT(m_new->wire_count == 0,
+ KASSERT(!vm_page_wired(m_new),
("page %p is wired", m_new));
/*
@@ -3435,7 +3435,7 @@
vm_page_assert_locked(m);
- if (m->wire_count > 0 || (m->oflags & VPO_UNMANAGED) != 0)
+ if (vm_page_wired(m) || (m->oflags & VPO_UNMANAGED) != 0)
return;
if (vm_page_queue(m) == PQ_ACTIVE) {
if (m->act_count < ACT_INIT)
@@ -3510,7 +3510,7 @@
m->valid = 0;
vm_page_undirty(m);
- if (m->wire_count != 0)
+ if (vm_page_wired(m) != 0)
panic("vm_page_free_prep: freeing wired page %p", m);
if (m->hold_count != 0) {
m->flags &= ~PG_ZERO;
@@ -3611,7 +3611,7 @@
m));
return;
}
- if (m->wire_count == 0) {
+ if (!vm_page_wired(m)) {
KASSERT((m->oflags & VPO_UNMANAGED) == 0 ||
m->queue == PQ_NONE,
("vm_page_wire: unmanaged page %p is queued", m));
@@ -3689,7 +3689,7 @@
("vm_page_unwire: fictitious page %p's wire count isn't one", m));
return (false);
}
- if (m->wire_count == 0)
+ if (!vm_page_wired(m))
panic("vm_page_unwire: page %p's wire count is zero", m);
m->wire_count--;
if (m->wire_count == 0) {
@@ -3711,7 +3711,7 @@
vm_page_assert_locked(m);
- if (m->wire_count > 0 || (m->oflags & VPO_UNMANAGED) != 0)
+ if (vm_page_wired(m) || (m->oflags & VPO_UNMANAGED) != 0)
return;
if (!vm_page_inactive(m)) {
@@ -3735,7 +3735,7 @@
vm_page_assert_locked(m);
- if (m->wire_count > 0 || (m->oflags & VPO_UNMANAGED) != 0)
+ if (vm_page_wired(m) || (m->oflags & VPO_UNMANAGED) != 0)
return;
if (!vm_page_inactive(m)) {
@@ -3757,7 +3757,7 @@
{
vm_page_assert_locked(m);
- if (m->wire_count > 0 || (m->oflags & VPO_UNMANAGED) != 0)
+ if (vm_page_wired(m) || (m->oflags & VPO_UNMANAGED) != 0)
return;
if (vm_page_in_laundry(m))
@@ -3778,7 +3778,7 @@
{
vm_page_assert_locked(m);
- KASSERT(m->wire_count == 0 && (m->oflags & VPO_UNMANAGED) == 0,
+ KASSERT(!vm_page_wired(m) && (m->oflags & VPO_UNMANAGED) == 0,
("page %p already unswappable", m));
vm_page_dequeue(m);
Index: sys/vm/vm_pageout.c
===================================================================
--- sys/vm/vm_pageout.c
+++ sys/vm/vm_pageout.c
@@ -754,7 +754,7 @@
*/
if (m->hold_count != 0)
continue;
- if (m->wire_count != 0) {
+ if (vm_page_wired(m)) {
vm_page_dequeue_deferred(m);
continue;
}
@@ -1203,7 +1203,7 @@
/*
* Wired pages are dequeued lazily.
*/
- if (m->wire_count != 0) {
+ if (vm_page_wired(m)) {
vm_page_dequeue_deferred(m);
continue;
}
@@ -1430,7 +1430,7 @@
addl_page_shortage++;
goto reinsert;
}
- if (m->wire_count != 0) {
+ if (vm_page_wired(m)) {
vm_page_dequeue_deferred(m);
continue;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, May 18, 6:20 PM (7 h, 15 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
33262453
Default Alt Text
D20485.id58162.diff (6 KB)
Attached To
Mode
D20485: Use the vm_page_wired() predicate where appropriate.
Attached
Detach File
Event Timeline
Log In to Comment