Page MenuHomeFreeBSD
Files F156578565

D41848.id127347.diff
No OneTemporary
Actions

D41848.id127347.diff
View Options

diff --git a/sys/dev/virtio/mmio/virtio_mmio.c b/sys/dev/virtio/mmio/virtio_mmio.c
--- a/sys/dev/virtio/mmio/virtio_mmio.c
+++ b/sys/dev/virtio/mmio/virtio_mmio.c
@@ -73,7 +73,7 @@
static int vtmmio_write_ivar(device_t, device_t, int, uintptr_t);
static uint64_t vtmmio_negotiate_features(device_t, uint64_t);
static int vtmmio_finalize_features(device_t);
-static int vtmmio_with_feature(device_t, uint64_t);
+static bool vtmmio_with_feature(device_t, uint64_t);
static void vtmmio_set_virtqueue(struct vtmmio_softc *sc,
struct virtqueue *vq, uint32_t size);
static int vtmmio_alloc_virtqueues(device_t, int, int,
@@ -489,7 +489,7 @@
return (0);
}
-static int
+static bool
vtmmio_with_feature(device_t dev, uint64_t feature)
{
struct vtmmio_softc *sc;
diff --git a/sys/dev/virtio/pci/virtio_pci.h b/sys/dev/virtio/pci/virtio_pci.h
--- a/sys/dev/virtio/pci/virtio_pci.h
+++ b/sys/dev/virtio/pci/virtio_pci.h
@@ -117,7 +117,7 @@
uint64_t vtpci_negotiate_features(struct vtpci_common *cn,
uint64_t child_features, uint64_t host_features);
-int vtpci_with_feature(struct vtpci_common *cn, uint64_t feature);
+bool vtpci_with_feature(struct vtpci_common *cn, uint64_t feature);
int vtpci_read_ivar(struct vtpci_common *cn, int index, uintptr_t *result);
int vtpci_write_ivar(struct vtpci_common *cn, int index, uintptr_t value);
diff --git a/sys/dev/virtio/pci/virtio_pci.c b/sys/dev/virtio/pci/virtio_pci.c
--- a/sys/dev/virtio/pci/virtio_pci.c
+++ b/sys/dev/virtio/pci/virtio_pci.c
@@ -267,7 +267,7 @@
return (features);
}
-int
+bool
vtpci_with_feature(struct vtpci_common *cn, uint64_t feature)
{
return ((cn->vtpci_features & feature) != 0);
diff --git a/sys/dev/virtio/pci/virtio_pci_legacy.c b/sys/dev/virtio/pci/virtio_pci_legacy.c
--- a/sys/dev/virtio/pci/virtio_pci_legacy.c
+++ b/sys/dev/virtio/pci/virtio_pci_legacy.c
@@ -86,8 +86,8 @@
struct vtpci_interrupt *);
static uint64_t vtpci_legacy_negotiate_features(device_t, uint64_t);
-static int vtpci_legacy_with_feature(device_t, uint64_t);
-static int vtpci_legacy_alloc_virtqueues(device_t, int, int,
+static bool vtpci_legacy_with_feature(device_t, uint64_t);
+static int vtpci_legacy_alloc_virtqueues(device_t, int,
struct vq_alloc_info *);
static int vtpci_legacy_setup_interrupts(device_t, enum intr_type);
static void vtpci_legacy_stop(device_t);
@@ -379,7 +379,7 @@
return (features);
}
-static int
+static bool
vtpci_legacy_with_feature(device_t dev, uint64_t feature)
{
struct vtpci_legacy_softc *sc;
diff --git a/sys/dev/virtio/pci/virtio_pci_modern.c b/sys/dev/virtio/pci/virtio_pci_modern.c
--- a/sys/dev/virtio/pci/virtio_pci_modern.c
+++ b/sys/dev/virtio/pci/virtio_pci_modern.c
@@ -111,8 +111,8 @@
static uint64_t vtpci_modern_negotiate_features(device_t, uint64_t);
static int vtpci_modern_finalize_features(device_t);
-static int vtpci_modern_with_feature(device_t, uint64_t);
-static int vtpci_modern_alloc_virtqueues(device_t, int, int,
+static bool vtpci_modern_with_feature(device_t, uint64_t);
+static int vtpci_modern_alloc_virtqueues(device_t, int,
struct vq_alloc_info *);
static int vtpci_modern_setup_interrupts(device_t, enum intr_type);
static void vtpci_modern_stop(device_t);
@@ -469,7 +469,7 @@
return (0);
}
-static int
+static bool
vtpci_modern_with_feature(device_t dev, uint64_t feature)
{
struct vtpci_modern_softc *sc;
diff --git a/sys/dev/virtio/virtio.h b/sys/dev/virtio/virtio.h
--- a/sys/dev/virtio/virtio.h
+++ b/sys/dev/virtio/virtio.h
@@ -92,7 +92,7 @@
int virtio_describe_sbuf(struct sbuf *sb, uint64_t features,
struct virtio_feature_desc *desc);
uint64_t virtio_filter_transport_features(uint64_t features);
-int virtio_bus_is_modern(device_t dev);
+bool virtio_bus_is_modern(device_t dev);
void virtio_read_device_config_array(device_t dev, bus_size_t offset,
void *dst, int size, int count);
@@ -106,7 +106,7 @@
int virtio_alloc_virtqueues(device_t dev, int flags, int nvqs,
struct vq_alloc_info *info);
int virtio_setup_intr(device_t dev, enum intr_type type);
-int virtio_with_feature(device_t dev, uint64_t feature);
+bool virtio_with_feature(device_t dev, uint64_t feature);
void virtio_stop(device_t dev);
int virtio_config_generation(device_t dev);
int virtio_reinit(device_t dev, uint64_t features);
diff --git a/sys/dev/virtio/virtio.c b/sys/dev/virtio/virtio.c
--- a/sys/dev/virtio/virtio.c
+++ b/sys/dev/virtio/virtio.c
@@ -200,7 +200,7 @@
return (features & mask);
}
-int
+bool
virtio_bus_is_modern(device_t dev)
{
uintptr_t modern;
@@ -275,7 +275,7 @@
return (VIRTIO_BUS_SETUP_INTR(device_get_parent(dev), type));
}
-int
+bool
virtio_with_feature(device_t dev, uint64_t feature)
{
diff --git a/sys/dev/virtio/virtio_bus_if.m b/sys/dev/virtio/virtio_bus_if.m
--- a/sys/dev/virtio/virtio_bus_if.m
+++ b/sys/dev/virtio/virtio_bus_if.m
@@ -56,7 +56,7 @@
device_t dev;
} DEFAULT virtio_bus_default_finalize_features;
-METHOD int with_feature {
+METHOD bool with_feature {
device_t dev;
uint64_t feature;
};
diff --git a/sys/dev/virtio/virtqueue.h b/sys/dev/virtio/virtqueue.h
--- a/sys/dev/virtio/virtqueue.h
+++ b/sys/dev/virtio/virtqueue.h
@@ -85,8 +85,8 @@
vm_paddr_t virtqueue_used_paddr(struct virtqueue *vq);
uint16_t virtqueue_index(struct virtqueue *vq);
-int virtqueue_full(struct virtqueue *vq);
-int virtqueue_empty(struct virtqueue *vq);
+bool virtqueue_full(struct virtqueue *vq);
+bool virtqueue_empty(struct virtqueue *vq);
int virtqueue_size(struct virtqueue *vq);
int virtqueue_nfree(struct virtqueue *vq);
int virtqueue_nused(struct virtqueue *vq);
diff --git a/sys/dev/virtio/virtqueue.c b/sys/dev/virtio/virtqueue.c
--- a/sys/dev/virtio/virtqueue.c
+++ b/sys/dev/virtio/virtqueue.c
@@ -128,7 +128,7 @@
static void vq_ring_update_avail(struct virtqueue *, uint16_t);
static uint16_t vq_ring_enqueue_segments(struct virtqueue *,
struct vring_desc *, uint16_t, struct sglist *, int, int);
-static int vq_ring_use_indirect(struct virtqueue *, int);
+static bool vq_ring_use_indirect(struct virtqueue *, int);
static void vq_ring_enqueue_indirect(struct virtqueue *, void *,
struct sglist *, int, int);
static int vq_ring_enable_interrupt(struct virtqueue *, uint16_t);
@@ -418,14 +418,14 @@
return (vq->vq_free_cnt);
}
-int
+bool
virtqueue_empty(struct virtqueue *vq)
{
return (vq->vq_nentries == vq->vq_free_cnt);
}
-int
+bool
virtqueue_full(struct virtqueue *vq)
{
@@ -733,20 +733,20 @@
return (idx);
}
-static int
+static bool
vq_ring_use_indirect(struct virtqueue *vq, int needed)
{
if ((vq->vq_flags & VIRTQUEUE_FLAG_INDIRECT) == 0)
- return (0);
+ return (false);
if (vq->vq_max_indirect_size < needed)
- return (0);
+ return (false);
if (needed < 2)
- return (0);
+ return (false);
- return (1);
+ return (true);
}
static void

File Metadata

Mime Type
text/plain
Expires
Fri, May 15, 7:54 PM (13 h, 31 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
33096823
Default Alt Text
D41848.id127347.diff (6 KB)

Event Timeline