Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F149597108
D11245.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
1 KB
Referenced Files
None
Subscribers
None
D11245.id.diff
View Options
Index: head/sys/arm/arm/pl310.c
===================================================================
--- head/sys/arm/arm/pl310.c
+++ head/sys/arm/arm/pl310.c
@@ -206,6 +206,10 @@
if ((pl310_softc == NULL) || !pl310_softc->sc_enabled)
return;
+ /* Do not sync outer cache on IO coherent platform */
+ if (pl310_softc->sc_io_coherent)
+ return;
+
#ifdef PL310_ERRATA_753970
if (pl310_softc->sc_rtl_revision == CACHE_ID_RELEASE_r3p0)
/* Write uncached PL310 register */
@@ -444,6 +448,7 @@
struct pl310_softc *sc = device_get_softc(dev);
int rid;
uint32_t cache_id, debug_ctrl;
+ phandle_t node;
sc->sc_dev = dev;
rid = 0;
@@ -469,6 +474,15 @@
device_printf(dev, "Part number: 0x%x, release: 0x%x\n",
(cache_id >> CACHE_ID_PARTNUM_SHIFT) & CACHE_ID_PARTNUM_MASK,
(cache_id >> CACHE_ID_RELEASE_SHIFT) & CACHE_ID_RELEASE_MASK);
+
+ /*
+ * Test for "arm,io-coherent" property and disable sync operation if
+ * platform is I/O coherent. Outer sync operations are not needed
+ * on coherent platform and may be harmful in certain situations.
+ */
+ node = ofw_bus_get_node(dev);
+ if (OF_hasprop(node, "arm,io-coherent"))
+ sc->sc_io_coherent = true;
/*
* If L2 cache is already enabled then something has violated the rules,
Index: head/sys/arm/include/pl310.h
===================================================================
--- head/sys/arm/include/pl310.h
+++ head/sys/arm/include/pl310.h
@@ -148,6 +148,7 @@
struct mtx sc_mtx;
u_int sc_rtl_revision;
struct intr_config_hook *sc_ich;
+ boolean_t sc_io_coherent;
};
/**
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 26, 12:46 PM (3 h, 40 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
30383017
Default Alt Text
D11245.id.diff (1 KB)
Attached To
Mode
D11245: Disable PL310 outer cache sync for IO coherent platforms
Attached
Detach File
Event Timeline
Log In to Comment