Page Menu
Home
FreeBSD
Search
Configure Global Search
Log In
Files
F144064300
D30253.id89186.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Flag For Later
Award Token
Size
3 KB
Referenced Files
None
Subscribers
None
D30253.id89186.diff
View Options
Index: sys/netinet/libalias/alias_db.c
===================================================================
--- sys/netinet/libalias/alias_db.c
+++ sys/netinet/libalias/alias_db.c
@@ -224,6 +224,10 @@
#define NO_DEST_PORT 1
#define NO_SRC_PORT 1
+/* Dummy address used for FindLinkIn/Out() and AddLink().
+ The value of this variable is never used. */
+static struct in_addr NO_ADDR;
+
/* Data Structures
The fundamental data structure used in this program is
@@ -1117,12 +1121,12 @@
lnk = _FindLinkOut(la, src_addr, dst_addr, src_port, 0,
link_type, 0);
if (lnk == NULL)
- lnk = _FindLinkOut(la, src_addr, la->nullAddress, src_port,
+ lnk = _FindLinkOut(la, src_addr, NO_ADDR, src_port,
dst_port, link_type, 0);
}
if (lnk == NULL &&
(dst_port != 0 || dst_addr.s_addr != INADDR_ANY)) {
- lnk = _FindLinkOut(la, src_addr, la->nullAddress, src_port, 0,
+ lnk = _FindLinkOut(la, src_addr, NO_ADDR, src_port, 0,
link_type, 0);
}
if (lnk != NULL) {
@@ -1158,7 +1162,7 @@
*/
if (la->aliasAddress.s_addr != INADDR_ANY &&
src_addr.s_addr == la->aliasAddress.s_addr) {
- lnk = _FindLinkOut(la, la->nullAddress, dst_addr, src_port, dst_port,
+ lnk = _FindLinkOut(la, NO_ADDR, dst_addr, src_port, dst_port,
link_type, replace_partial_links);
}
}
@@ -1301,7 +1305,7 @@
*/
if (la->aliasAddress.s_addr != INADDR_ANY &&
alias_addr.s_addr == la->aliasAddress.s_addr) {
- lnk = _FindLinkIn(la, dst_addr, la->nullAddress, dst_port, alias_port,
+ lnk = _FindLinkIn(la, dst_addr, NO_ADDR, dst_port, alias_port,
link_type, replace_partial_links);
}
}
@@ -1383,7 +1387,7 @@
LINK_FRAGMENT_ID, 0);
if (lnk == NULL) {
- lnk = AddLink(la, la->nullAddress, dst_addr, alias_addr,
+ lnk = AddLink(la, NO_ADDR, dst_addr, alias_addr,
NO_SRC_PORT, NO_DEST_PORT, ip_id,
LINK_FRAGMENT_ID);
}
@@ -1409,7 +1413,7 @@
{
LIBALIAS_LOCK_ASSERT(la);
- return AddLink(la, la->nullAddress, dst_addr, la->nullAddress,
+ return AddLink(la, NO_ADDR, dst_addr, NO_ADDR,
NO_SRC_PORT, NO_DEST_PORT, ip_id,
LINK_FRAGMENT_PTR);
}
@@ -1420,7 +1424,7 @@
{
LIBALIAS_LOCK_ASSERT(la);
- return FindLinkIn(la, dst_addr, la->nullAddress,
+ return FindLinkIn(la, dst_addr, NO_ADDR,
NO_DEST_PORT, ip_id,
LINK_FRAGMENT_PTR, 0);
}
@@ -1680,7 +1684,7 @@
struct alias_link *lnk;
LIBALIAS_LOCK_ASSERT(la);
- lnk = FindLinkIn(la, la->nullAddress, alias_addr,
+ lnk = FindLinkIn(la, NO_ADDR, alias_addr,
0, 0, LINK_ADDR, 0);
if (lnk == NULL) {
la->newDefaultLink = 1;
@@ -1712,7 +1716,7 @@
struct alias_link *lnk;
LIBALIAS_LOCK_ASSERT(la);
- lnk = FindLinkOut(la, original_addr, la->nullAddress,
+ lnk = FindLinkOut(la, original_addr, NO_ADDR,
0, 0, LINK_ADDR, 0);
if (lnk == NULL) {
return (la->aliasAddress.s_addr != INADDR_ANY) ?
@@ -2337,7 +2341,7 @@
struct alias_link *lnk;
LIBALIAS_LOCK(la);
- lnk = AddLink(la, src_addr, la->nullAddress, alias_addr,
+ lnk = AddLink(la, src_addr, NO_ADDR, alias_addr,
0, 0, 0,
LINK_ADDR);
Index: sys/netinet/libalias/alias_local.h
===================================================================
--- sys/netinet/libalias/alias_local.h
+++ sys/netinet/libalias/alias_local.h
@@ -93,9 +93,6 @@
/* are sent to if no aliasing */
/* link already exists */
- struct in_addr nullAddress; /* Used as a dummy parameter for */
- /* some function calls */
-
LIST_HEAD (, alias_link) linkTableOut[LINK_TABLE_OUT_SIZE];
/* Lookup table of pointers to */
/* chains of link records. Each */
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Feb 5, 4:01 AM (7 h, 26 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
28440034
Default Alt Text
D30253.id89186.diff (3 KB)
Attached To
Mode
D30253: libalias: replace placeholder with static constant
Attached
Detach File
Event Timeline
Log In to Comment