Page MenuHomeFreeBSD

editors/jove: Fix crashes
ClosedPublic

Authored by tobik on Mar 3 2017, 11:39 PM.

Details

Summary
JOVE defines a getline function that collides with getline(3).
r419275 tried to fix it by renaming it to get_line, but a few renames
were missed leading to crashes when trying to run JOVE.  Finish the
previous work and also add LICENSE while here.

PR:		217516
Submitted by:	crahman@gmail.com (based on)
Reviewed by:	crahman@gmail.com
Approved by:	??? (mentor)
Differential Revision:	https://reviews.freebsd.org/D????
Test Plan

poudriere testport 11.0/amd64 ok
poudriere testport 10.3/i386 ok

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tobik updated this revision to Diff 25959.Mar 3 2017, 11:39 PM
tobik retitled this revision from to editors/jove: Fix crashes.
tobik updated this object.
tobik edited the test plan for this revision. (Show Details)
tobik added reviewers: lme, mat.
mat accepted this revision.Mar 3 2017, 11:52 PM
mat edited edge metadata.
mat added inline comments.
editors/jove/Makefile
25 ↗(On Diff #25959)

Maybe you should anchor getline, a bit like s|[[:<:]]getline[[:>:]]|get_line| so that it does not replace longer versions of that string.

This revision is now accepted and ready to land.Mar 3 2017, 11:52 PM
This revision was automatically updated to reflect the committed changes.