Page MenuHomeFreeBSD

editors/jove: Fix crashes

Authored by tobik on Mar 3 2017, 11:39 PM.
Referenced Files
Unknown Object (File)
Sat, Nov 11, 8:32 AM
Unknown Object (File)
Thu, Nov 9, 8:34 AM
Unknown Object (File)
Oct 13 2023, 5:54 PM
Unknown Object (File)
Oct 12 2023, 4:29 PM
Unknown Object (File)
Oct 8 2023, 7:30 AM
Unknown Object (File)
Oct 3 2023, 10:29 AM
Unknown Object (File)
Oct 3 2023, 10:28 AM
Unknown Object (File)
Oct 3 2023, 10:25 AM


JOVE defines a getline function that collides with getline(3).
r419275 tried to fix it by renaming it to get_line, but a few renames
were missed leading to crashes when trying to run JOVE.  Finish the
previous work and also add LICENSE while here.

PR:		217516
Submitted by: (based on)
Reviewed by:
Approved by:	??? (mentor)
Differential Revision:
Test Plan

poudriere testport 11.0/amd64 ok
poudriere testport 10.3/i386 ok

Diff Detail

rP FreeBSD ports repository
Lint Not Applicable
Tests Not Applicable

Event Timeline

tobik retitled this revision from to editors/jove: Fix crashes.
tobik updated this object.
tobik edited the test plan for this revision. (Show Details)
tobik added reviewers: lme, mat.
mat edited edge metadata.
mat added inline comments.
25 ↗(On Diff #25959)

Maybe you should anchor getline, a bit like s|[[:<:]]getline[[:>:]]|get_line| so that it does not replace longer versions of that string.

This revision is now accepted and ready to land.Mar 3 2017, 11:52 PM
This revision was automatically updated to reflect the committed changes.