mail/py-dkimpy: Update to 0.6.1
ClosedPublic
Actions

Authored by tobik on Feb 21 2017, 6:46 PM.

Details

Reviewers

lme
mat

Commits

rP434591: Update to 0.6.1

Summary

Update to 0.6.1

Changes:  http://bazaar.launchpad.net/~dkimpy-hackers/dkimpy/trunk/view/131/ChangeLog
PR:    217277
Submitted by:	Kevin Golding <ports@caomhin.org> (maintainer)
Approved by:	??? (mentor)
Differential Revision:	https://reviews.freebsd.org/D????

Test Plan

poudriere testport FreeBSD 11.0/amd64 ok
poudriere testport FreeBSD 10.3/i386 ok

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobik updated this revision to Diff 25488.Feb 21 2017, 6:46 PM

tobik retitled this revision from to mail/py-dkimpy: Update to 0.6.1.

tobik updated this object.

tobik edited the test plan for this revision. (Show Details)

tobik added reviewers: lme, mat.

mat added inline comments.Feb 22 2017, 8:00 AM

mail/py-dkimpy/Makefile
19 ↗	(On Diff #25488)	I think this is wrong, it should be `python:2.7`.

tobik added inline comments.Feb 22 2017, 12:00 PM

mail/py-dkimpy/Makefile
19 ↗	(On Diff #25488)	Why? `python:2` seems to be a valid value according to `python.mk`. `dns/py-dns` uses the same as do a lot of other ports. You approved the update for `www/py-fedex` in D9703 which also uses `python:2`. Should I change it to `python:2.7` there too?

mat added inline comments.Feb 22 2017, 2:07 PM

mail/py-dkimpy/Makefile
19 ↗	(On Diff #25488)	Because `python:2` does not do what you think it does. It depends on python version ${DEFAULT_PYTHON2} and installs a /usr/local/bin/python2 symlink to /usr/local/bin/python2.x. If your port needs python 2.x, but does not need the python2 symlink, say `USES=python:2.7`. As a rule of the thumb, never USES=python:2. As for D9703, it should probably also be changed to python:2.7.