Add sem_clockwait_np()
ClosedPublic
Actions

Authored by vangyzen on Feb 17 2017, 9:16 PM.

Details

Reviewers

Commits

rS314179: Add sem_clockwait_np()

Summary

This function allows the caller to specify the reference clock
and choose between absolute and relative mode. In relative mode,
the remaining time can be returned.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vangyzen updated this revision to Diff 25333.Feb 17 2017, 9:16 PM

vangyzen retitled this revision from to Add sem_timedwait5_np().

vangyzen updated this object.

vangyzen edited the test plan for this revision. (Show Details)

Herald added a subscriber: badger. · View Herald TranscriptFeb 17 2017, 9:16 PM

I have only compile-tested this. I still need to write unit tests.

https://github.com/vangyzen/freebsd/tree/sem_timedwait5

ed added a subscriber: ed.Feb 18 2017, 10:22 AM

ed added inline comments.

include/semaphore.h
62 ↗	(On Diff #25333)	Hmmm... I'm not a fan of this. This means that if you include `<semaphore.h>` once without exposing this function, there is no way to get it later on. Saying: "just make sure to include stuff in the right order" won't work in practice. What if you make use of some kind of library that suddenly decides to start using semaphores in its header files from one version to the other? That will break the build in unforeseen ways. The only sensible thing is to use `__clockid_t`.
63 ↗	(On Diff #25333)	What about calling this `sem_clock_timedwait()`?
63 ↗	(On Diff #25333)	Correction: `sem_clock_timedwait_np()`.

vangyzen added inline comments.Feb 18 2017, 3:06 PM

include/semaphore.h
62 ↗	(On Diff #25333)	I completely agree. I pulled most of this from a commercial appliance and failed to revisit this part before uploading...even though I remembered it when I updated the man page! Thanks for catching it.
63 ↗	(On Diff #25333)	I've been looking for a better name, too. I like your suggestion. How about `sem_clockwait_np()`? It's shorter, but it still describes the behavior well enough. It's also consistent with other functions like `sem_timedwait` and `sem_trywait`.