New Port: misc/minio-client

[krion]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217124

Minio Client is a replacement for ls, cp, mkdir, diff and rsync commands for
filesystems and object storage.

WWW: https://minio.io/downloads/#minio-client

[mat]

www/minio-client/Makefile

18 ↗

(On Diff #25288)

Maintaining both PORTVERSION and GH_TAGNAME is going to be painful, maybe you could either set DISTVERSIONPREFIX, DISTVERSION and DISTVERSIONSUFFIX, or you could compute PORTVERSION from GH_TAGNAME.

[krion]

It could be possible yes, with:

PORTVERSION= 2017.02.06T20.16.19
DISTVERSIONPREFIX= -RELEASE.
CATEGORIES= www
DISTNAME= ${GH_ACCOUNT}${GH_PROJECT}${PORTVERSION:S/T/./}${DISTVERSIONPREFIX}${PORTVERSION:S/./-/g}Z

it prints out the right distfile name, but when it starts to download from github, it expands the URL to:

https://codeload.github.com/minio/mc/tar.gz/-RELEASE.2017.02.06T20.16.19?dummy=/minio-mc-2017.02.06.20.16.19-RELEASE.2017-02-06T20-16-19Z_GH0.tar.gz

Instead of:

https://codeload.github.com/minio/mc/tar.gz/RELEASE.2017-02-06T20-16-19Z?dummy=/minio-mc-2017.02.06.20.16.19-RELEASE.2017-02-06T20-16-19Z_GH0.tar.gz

Which makes whole game useless, so I better leave it as-is, it's up to maintainer to take care of it later, IMHO.

[mat]

When using USE_GITHUB, NEVER set DISTNAME, because it must be generated by the framework.

I think that doing:

PORTVERSION= ${GH_TAGNAME:S/RELEASE.//:S/Z$//:S/T/-:S/-/./g}

would do the trick.

Otherwise, you could do:

DISTVERSIONPREFIX= RELEASE.
DISTVERSION=       2017-02-06T20-16-19
DISTVERSIONSUFFIX= Z

[krion]

BTW, not setting DISTNAME with USE_GITHUB is not documented in Porters Handbook.

Nope,

PORTVERSION= ${GH_TAGNAME:S/RELEASE.//:S/Z$//:S/T/-:S/-/./g}

wouldn't work as distfile looks like:
minio-mc-2017.02.06.20.16.19-RELEASE.2017-02-06T20-16-19Z_GH0.tar.gz

[mat]

In D9642#199418, @krion wrote:

BTW, not setting DISTNAME with USE_GITHUB is not documented in Porters Handbook.

I know.

Nope,

PORTVERSION= ${GH_TAGNAME:S/RELEASE.//:S/Z$//:S/T/-:S/-/./g}

wouldn't work as distfile looks like:
minio-mc-2017.02.06.20.16.19-RELEASE.2017-02-06T20-16-19Z_GH0.tar.gz

I don't understand the problem, it looks like a perfectly reasonable name for it.

[krion]

You can't use

PORTVERSION= ${GH_TAGNAME:S/RELEASE.//:S/Z$//:S/T/-:S/-/./g}

because it contains "-" so it breaks make.

[mat]

Then use DISTVERSION instead, it'll clean things up.

[mat]

Sorry, way, no, it does not. There is no - in 2017.02.06.20.16.19.

[krion]

Right, without 2017.02.06.20.16.19 I can't proceed

[mat]

With the PORVERSION change I proposed, what does make -V PKGNAME says ? I'm sure it says the right thing.

[krion]

% make -V PKGNAME
make: Unknown modifier '-'
make: Unknown modifier '-'
make: Unknown modifier '-'
make: "/usr/home/krion/ports/Mk/bsd.sites.mk" line 527: Undefined variable "${GH_TAGNAME:S/RELEASE.//:S/Z$//:S/T/-:S/-/./g}"
make: Unknown modifier '-'
make: Unknown modifier '-'
make: Unknown modifier '-'
make: Unknown modifier '-'
make: Unknown modifier '-'
make: Unknown modifier '-'
make: Unknown modifier '-'
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/home/krion/ports/www/minio-client

[mat]

There was a / missing, this works:

PORTVERSION=    ${GH_TAGNAME:S/RELEASE.//:S/Z//:S/T/-/:S/-/./g}

[krion]

Oh gosh, yes, now it works

[krion]

Update diff with new PORTVERSION