Page MenuHomeFreeBSD

Add audio/gstreamer1-plugins-sndio
ClosedPublic

Authored by tobik on Feb 15 2017, 5:30 PM.

Details

Summary
New port: audio/gstreamer1-plugins-sndio

An sndio audio sink and source for GStreamer1

WWW: https://github.com/t6/gstreamer1-plugins-sndio/

PR:	215904
Approved by:	??? (mentor)
Differential Revision:	https://reviews.freebsd.org/D????
Test Plan

poudriere testport 10.3/i386, 10.3/amd64, 11.0/amd64 ok
portlint -AC ok

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tobik retitled this revision from to Add audio/gstreamer1-plugins-sndio.
tobik updated this object.
tobik edited the test plan for this revision. (Show Details)
tobik added reviewers: lme, mat.

Use my FreeBSD email address

mat requested changes to this revision.Feb 15 2017, 10:22 PM
mat edited edge metadata.
mat added inline comments.
audio/gstreamer1-plugins-sndio/Makefile
11 ↗(On Diff #25240)

If the software has a license file in the sources, please add a LICENSE_FILE line here.

audio/gstreamer1-plugins-sndio/pkg-descr
1 ↗(On Diff #25240)

This is the same as the COMMENT, pkg-descr is where you put a longer description (a paragraph, at least) of what this does.

audio/gstreamer1-plugins-sndio/pkg-message
1–3 ↗(On Diff #25240)

A few bits about how we write documentation:

  • never address people directly (never use "you")
  • never contract (so, "you have", not "you've")

So, something more along the lines of:

The GStreamer sndio plugin has been installed. It has a higher ...

This revision now requires changes to proceed.Feb 15 2017, 10:22 PM
tobik edited edge metadata.

Better pkg-descr and pkg-message

The sources have the license in the file headers only, so there is no
separate license file.

lme edited edge metadata.

I'm okay with it. portlint also likes it.

This revision was automatically updated to reflect the committed changes.