Page MenuHomeFreeBSD
Differential D953

Update vt(4) for UEFI defaults and special keys
ClosedPublic
Actions

Authored by emaste on Oct 16 2014, 2:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 8:49 PM
Unknown Object (File)
Sun, Jan 19, 11:38 AM
Unknown Object (File)
Fri, Jan 3, 2:42 AM
Unknown Object (File)
Fri, Jan 3, 2:42 AM
Unknown Object (File)
Fri, Jan 3, 2:42 AM
Unknown Object (File)
Fri, Jan 3, 2:42 AM
Unknown Object (File)
Fri, Jan 3, 2:41 AM
Unknown Object (File)
Thu, Jan 2, 8:45 PM
View All Files
Subscribers
wblock

Details

Reviewers
wblock
Group Reviewers
Doc Committers
Commits
rS273178: Update vt(4) for UEFI defaults and special keys
Summary

vt(4) is the default console for UEFI boot [1], and the bitmapped kern.vt.spclkeys sysctl has been replaced with individual kern.vt.kbd_* enable sysctls.

PR: 193710 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193710
Submitted by: wblock [1]
MFC After: 3 days
Relnotes: Yes

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 2002.Oct 16 2014, 2:35 PM
emaste retitled this revision from to Update vt(4) for UEFI defaults and special keys .
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: Doc Committers.
wblock added a subscriber: wblock.Oct 16 2014, 5:51 PM
wblock added inline comments.
share/man/man4/vt.4
216 ↗(On Diff #2002)

The mention of .Xr keymap 5 can be factored out to a single mention at the beginning. It might be a mistake to mention the defaults, since those are probably dependent on the keymap.

.Sh Keymap Settings

These settings control whether certain key combinations are enabled or ignored. See
.Xr keymap 5
.Bl -tag -width indent
...

(untested, probably needs more markup)

emaste updated this revision to Diff 2004.Oct 16 2014, 6:04 PM

Try to capture Warren's comments

wblock added inline comments.Oct 16 2014, 6:09 PM
share/man/man4/vt.4
209 ↗(On Diff #2004)

Prefer "can" for "it is possible" to "may" which often means "you have permission".

226 ↗(On Diff #2004)

The parens make for more of an aside. Maybe just "...combination, usually Ctrl+Alt+Del. Likewise for the next entry.

emaste updated this revision to Diff 2005.Oct 16 2014, 6:15 PM

wblock comments round 2

wblock accepted this revision.Oct 16 2014, 6:45 PM
wblock added a reviewer: wblock.

Works for me. Thanks!

This revision is now accepted and ready to land.Oct 16 2014, 6:45 PM
emaste closed this revision.Oct 16 2014, 6:50 PM
emaste updated this revision to Diff 2006.

Closed by commit rS273178 (authored by @emaste).

Revision Contents
Changeset List

PathSize
head/
share/
man/
man4/
65 lines

Diff 2006

View Options

head/share/man/man4/vt.4

Loading...