Paths

Table of Contentst

Differential D9439

Update math/cadabra2 to 2.1.2 Supersedes D9415
ClosedPublic
Actions

Authored by krion on Feb 4 2017, 5:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 16 2024, 8:00 PM

	Unknown Object (File)
	Mar 16 2024, 8:00 PM

	Unknown Object (File)
	Mar 16 2024, 8:00 PM

	Unknown Object (File)
	Mar 16 2024, 7:59 PM

	Unknown Object (File)
	Mar 15 2024, 12:52 PM

	Unknown Object (File)
	Mar 14 2024, 5:19 AM

	Unknown Object (File)
	Jan 7 2024, 5:09 PM

	Unknown Object (File)
	Jan 7 2024, 5:09 PM

View All 49 Files

Subscribers

None

Details

Reviewers

fjoe
mat

Commits

rP433379: Update math/cadabra2 to 2.1.2

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216717

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

krion updated this revision to Diff 24725.Feb 4 2017, 5:39 PM

krion retitled this revision from to Update math/cadabra2 to 2.1.2 Supersedes D9415.

krion updated this object.

krion edited the test plan for this revision. (Show Details)

krion added reviewers: mat, fjoe.

krion mentioned this in D9415: Update math/cadabra2 to 2.1.2.Feb 4 2017, 5:41 PM

mat added inline comments.Feb 4 2017, 6:22 PM

math/cadabra2/Makefile
42–43 ↗	(On Diff #24725)	These should be `GUI_CMAKE_BOOL= FRONTEND`.
64–71 ↗	(On Diff #24725)	All those sed affect the same file, you should fold them into one.
80 ↗	(On Diff #24725)	`GZIP_CMD` already includes `GZIP`

krion added inline comments.Feb 4 2017, 7:41 PM

math/cadabra2/Makefile
42–43 ↗	(On Diff #24725)	Yes, right, sorry I didn't catch it in cmake docs
64–71 ↗	(On Diff #24725)	will redo
80 ↗	(On Diff #24725)	will be fixed as well

There're changes proposed by mat, please review.

Updating D9439: Update math/cadabra2 to 2.1.2

Supersedes D9415

mat accepted this revision.Feb 5 2017, 7:06 AM

mat edited edge metadata.

This revision is now accepted and ready to land.Feb 5 2017, 7:06 AM

Closed by commit rP433379: Update math/cadabra2 to 2.1.2 (authored by krion). · Explain WhyFeb 5 2017, 7:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

math/

cadabra2/

33 lines

6 lines

files/

patch-client__server_CMakeLists.txt

22 lines

patch-frontend_gtkmm_CMakeLists.txt

28 lines

27 lines

Diff 24757

head/math/cadabra2/Makefile

Loading...

head/math/cadabra2/distinfo

Loading...

head/math/cadabra2/files/patch-client__server_CMakeLists.txt

Loading...

head/math/cadabra2/files/patch-frontend_gtkmm_CMakeLists.txt

Loading...

head/math/cadabra2/pkg-plist

Loading...