Page MenuHomeFreeBSD

[NEW PORT] net-mgmt/networkmgr
ClosedPublic

Authored by krion on Feb 1 2017, 3:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 1:51 PM
Unknown Object (File)
Fri, Apr 19, 1:51 PM
Unknown Object (File)
Fri, Apr 19, 1:51 PM
Unknown Object (File)
Fri, Apr 19, 1:51 PM
Unknown Object (File)
Fri, Apr 19, 1:50 PM
Unknown Object (File)
Fri, Apr 19, 1:50 PM
Unknown Object (File)
Tue, Apr 16, 4:05 PM
Unknown Object (File)
Wed, Mar 27, 8:03 PM
Subscribers
None

Details

Summary

NetworkMgr is an open source, Network Manager based on the look of the Linux
Network Manager user interface. It use ifconfig and netif if make all work.

WWW: https://github.com/GhostBSD/networkmgr

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

krion retitled this revision from to [NEW PORT] net-mgmt/networkmgr.
krion updated this object.
krion edited the test plan for this revision. (Show Details)
krion added a reviewer: mat.

I really do not like the pkg-install file, for one, it does not cleanup on deinstall, and more important, it changes another ports configuration file. I think this port should add a ${EXAMPLESDIR}/doas.conf with the lines it needs, and tell the user in pkg-message to go look there and copy the content manually.

net-mgmt/networkmgr/Makefile
12 ↗(On Diff #24626)

BSD is deprecated and should not be used. Use BSD[234]CLAUSE, whichever applies.

net-mgmt/networkmgr/pkg-install
7–8 ↗(On Diff #24626)
if ! ​grep -q 'permit nopass keepenv :wheel cmd netcardmgr' ${PKG_PREFIX}/etc/doas.conf 2>/dev/null; then

Same for all the others.

In D9405#194444, @mat wrote:

I really do not like the pkg-install file, for one, it does not cleanup on deinstall, and more important, it changes another ports configuration file. I think this port should add a ${EXAMPLESDIR}/doas.conf with the lines it needs, and tell the user in pkg-message to go look there and copy the content manually.

Yes, it's valid point, I will redo this port with maintainer's agreement

krion edited edge metadata.

I've re-created this port as requested, please review and add your comments if any.

net-mgmt/networkmgr/Makefile
19 ↗(On Diff #24773)

Does this need bin/python2 ? If not, it should be using USES=python:2.7

23 ↗(On Diff #24773)

No real point in setting this.

net-mgmt/networkmgr/pkg-plist
3 ↗(On Diff #24773)

Simply say etc/xdg...

  • Changed python version to 2.7
  • Removed ETCDIR from Makefile
mat edited edge metadata.
This revision is now accepted and ready to land.Feb 6 2017, 8:03 AM
This revision was automatically updated to reflect the committed changes.