improve style
ClosedPublic
Actions

Authored by kczekirda on Jan 31 2017, 12:23 PM.

Details

Reviewers

bapt
oshogbo

Commits

rS314945: Some style(9) fixes. No functional changes.

Summary

no functional change

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kczekirda updated this revision to Diff 24591.Jan 31 2017, 12:23 PM

kczekirda retitled this revision from to replacing spaces by tabs.

kczekirda updated this object.

kczekirda edited the test plan for this revision. (Show Details)

kczekirda added reviewers: oshogbo, bapt.

Missing lines which need some love:
64, 130, 133, 134, 145, 155, 157, 166, 178, 427,

/usr/src/sys/boot/i386/libi386/pxe.c
224 ↗	(On Diff #24591)	[tab]printf( [tab][4 spaces]args, Described in styl(9).
228 ↗	(On Diff #24591)	up
231 ↗	(On Diff #24591)	up
250 ↗	(On Diff #24591)	4 spaces, not tab
274 ↗	(On Diff #24591)	Missing tab.
278 ↗	(On Diff #24591)	missing tab. [tab]if (pxe_debug) [tab][tab]sth. style(9)
342 ↗	(On Diff #24591)	Sth, is wrong here, you can't have two } on same level ;(
354 ↗	(On Diff #24591)	MIssing tab, there are a lot missing tabs afters ifs, from this point, you will see them: You can't have if (sth) sth2; You need to have if (sth) sth2;
396 ↗	(On Diff #24591)	The same mistake with print as above.

This revision now requires changes to proceed.Feb 8 2017, 11:58 PM

oshogbo's comments fixed and some new improvements

It's looks good.

This revision is now accepted and ready to land.Feb 24 2017, 11:30 PM

Closed by commit rS314945: Some style(9) fixes. No functional changes. (authored by oshogbo). · Explain WhyMar 9 2017, 5:13 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

i386/

libi386/

pxe.c

311 lines

Diff 26087

View Options

head/sys/boot/i386/libi386/pxe.c

improve styleClosedPublicActions