Page MenuHomeFreeBSD

improve style
ClosedPublic

Authored by kczekirda on Jan 31 2017, 12:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 4:11 AM
Unknown Object (File)
Fri, Nov 22, 4:58 PM
Unknown Object (File)
Fri, Nov 22, 4:55 PM
Unknown Object (File)
Nov 8 2024, 7:50 AM
Unknown Object (File)
Oct 20 2024, 7:07 AM
Unknown Object (File)
Oct 19 2024, 9:31 AM
Unknown Object (File)
Oct 16 2024, 4:15 AM
Unknown Object (File)
Oct 5 2024, 12:53 AM
Subscribers
None

Details

Summary

no functional change

Sponsored by: Oktawave

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kczekirda retitled this revision from to replacing spaces by tabs.
kczekirda updated this object.
kczekirda edited the test plan for this revision. (Show Details)
kczekirda added reviewers: oshogbo, bapt.
oshogbo requested changes to this revision.Feb 8 2017, 11:58 PM
oshogbo edited edge metadata.

Missing lines which need some love:
64, 130, 133, 134, 145, 155, 157, 166, 178, 427,

/usr/src/sys/boot/i386/libi386/pxe.c
224 ↗(On Diff #24591)

[tab]printf(
[tab][4 spaces]args,

Described in styl(9).

228 ↗(On Diff #24591)

up

231 ↗(On Diff #24591)

up

250 ↗(On Diff #24591)

4 spaces, not tab

274 ↗(On Diff #24591)

Missing tab.

278 ↗(On Diff #24591)

missing tab.
[tab]if (pxe_debug)
[tab][tab]sth.
style(9)

342 ↗(On Diff #24591)

Sth, is wrong here, you can't have two } on same level ;(

354 ↗(On Diff #24591)

MIssing tab, there are a lot missing tabs afters ifs, from this point, you will see them:

You can't have
if (sth)
sth2;

You need to have
if (sth)

sth2;
396 ↗(On Diff #24591)

The same mistake with print as above.

This revision now requires changes to proceed.Feb 8 2017, 11:58 PM
kczekirda retitled this revision from replacing spaces by tabs to improve style.
kczekirda edited edge metadata.
kczekirda marked 9 inline comments as done.

oshogbo's comments fixed and some new improvements

oshogbo edited edge metadata.

It's looks good.

This revision is now accepted and ready to land.Feb 24 2017, 11:30 PM
This revision was automatically updated to reflect the committed changes.