Page MenuHomeFreeBSD

databases/mysql56-server: Fix build with LibreSSL
ClosedPublic

Authored by brnrd on Jan 21 2017, 11:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 10:51 PM
Unknown Object (File)
Mar 12 2024, 6:27 AM
Unknown Object (File)
Feb 17 2024, 1:32 AM
Unknown Object (File)
Dec 20 2023, 4:16 AM
Unknown Object (File)
Dec 10 2023, 8:04 AM
Unknown Object (File)
Dec 1 2023, 7:56 AM
Unknown Object (File)
Nov 10 2023, 2:10 AM
Unknown Object (File)
Oct 9 2023, 12:55 AM
Subscribers

Details

Summary
databases/mysql56-server: Fix build with LibreSSL

  - Fix CMake SSL detection
  - Always set WITH_SSL=${OPENSSLBASE}

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brnrd retitled this revision from to databases/mysql56-server: Fix build with LibreSSL.
brnrd updated this object.
brnrd edited the test plan for this revision. (Show Details)
brnrd added a reviewer: mmokhi.

I already worked on a patch and tested it,
Would you please check it too?

databases/mysql56-client/files/patch-cmake_ssl.cmake
1 ↗(On Diff #24272)

The patch you have in 216311 should actually look for LIBRESSL_VERSION_NUMBER, not OPENSSL_MAJOR_VERSION. Not sure how to do that.

8 ↗(On Diff #24272)

This is actually incorrect. With cmake 3.7 it should be VERSION_GREATER_EQUAL

databases/mysql56-client/files/patch-cmake_ssl.cmake
1 ↗(On Diff #24272)

Using new variable (LIBRESSL_VERSION_NUMBER instead of OPENSSL_MAJOR_VERSION) is not necessary i guess, because the script will fill OPENSSL_MAJOR_VERSION with any found info inside $OPENSSL_BASE.

Changing the name makes script much more readable though ;-)
But currently it works.

brnrd edited edge metadata.

Update diff to VERSION_GREATER_EQUAL

mmokhi edited edge metadata.

Okay, Looks good to me.
Thanks :-)

This revision is now accepted and ready to land.Jan 21 2017, 12:59 PM
This revision was automatically updated to reflect the committed changes.