Improve readability of warning/error display
ClosedPublic
Actions

Authored by AMDmi3 on Jan 17 2017, 3:53 PM.

Details

Reviewers

Group Reviewers

O5: Ports Framework	(Owns No Changed Paths)
portmgr

Commits

rP438169: - Make warning, dev warning, and dev error display consistent and more readable:

Summary

Split all messages with a newline
Run all messages throung fmt

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 6834
Build 7037: arc lint + arc unit

Event Timeline

AMDmi3 updated this revision to Diff 24120.Jan 17 2017, 3:53 PM

AMDmi3 retitled this revision from to Improve readability of warning/error display.

AMDmi3 updated this object.

AMDmi3 edited the test plan for this revision. (Show Details)

Owners added a reviewer: O5: Ports Framework.Jan 17 2017, 3:53 PM

Herald added a reviewer: portmgr. · View Herald TranscriptJan 17 2017, 3:53 PM

Herald added a subscriber: mat. · View Herald Transcript

I like this.

Also, there are quite a lot occurrences of those magical 75 and 79 numbers used with ${FMT} all over Mk, maybe there should be a FMT_80 or something defined as ${FMT} 75 79 so that one does not have to wander what magical numbers to use.

mat accepted this revision.Feb 21 2017, 12:54 PM

mat added a reviewer: mat.

This revision is now accepted and ready to land.Feb 21 2017, 12:54 PM

Closed by commit rP438169: - Make warning, dev warning, and dev error display consistent and more readable: (authored by AMDmi3). · Explain WhyApr 10 2017, 2:23 PM

This revision was automatically updated to reflect the committed changes.

AMDmi3 mentioned this in rP438169: - Make warning, dev warning, and dev error display consistent and more readable:.

AMDmi3 mentioned this in D10342: Use macro for ${FMT} 75 79.Apr 10 2017, 2:27 PM

Revision Contents
Changeset List

Path

Size

Mk/

bsd.port.mk

13 lines

Diff 24120

View Options

Improve readability of warning/error displayClosedPublicActions