editors/sublime: amend patches
ClosedPublic
Actions

Authored by xmj on Oct 7 2014, 1:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sep 27 2024, 8:02 AM

	Unknown Object (File)
	Sep 9 2024, 2:01 AM

	Unknown Object (File)
	Sep 8 2024, 12:34 PM

	Unknown Object (File)
	Aug 15 2024, 1:39 AM

	Unknown Object (File)
	May 24 2024, 11:04 PM

	Unknown Object (File)
	Apr 27 2024, 1:11 AM

	Unknown Object (File)
	Feb 13 2024, 10:52 PM

	Unknown Object (File)
	Feb 13 2024, 6:17 PM

View All 71 Files

Subscribers

Details

Reviewers

swills
koobs

Summary

Remove an import statement in patched PackageSetupy.py that was deprecated
before python 2.7

Test Plan

http://xmj.me/freebsd/buildlogs/sublime-2.0.2_1.log

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

xmj updated this revision to Diff 1905.Oct 7 2014, 1:18 PM

xmj retitled this revision from to editors/sublime: amend patches.

xmj updated this object.

xmj edited the test plan for this revision. (Show Details)

xmj added reviewers: swills, koobs.

Approved, looks fine.

This revision is now accepted and ready to land.Oct 7 2014, 2:09 PM

Committed revision 370338.

It is work here:

Python 2.7.8 (default, Sep 25 2014, 23:51:23) 
[GCC 4.2.1 Compatible FreeBSD Clang 3.4.1 (tags/RELEASE_34/dot1-final 208032)] on freebsd11
Type "help", "copyright", "credits" or "license" for more information.
>>> from __future__ import with_statement
>>>

But it doesn't needed on python 2.7 because "with" works out of the box. Anyway, what problem this patch is solving?