Page MenuHomeFreeBSD

multimedia/mpv: update to 0.23.0
ClosedPublic

Authored by jbeich on Dec 26 2016, 12:31 PM.

Details

Summary
Test Plan

portlint -C -> looks fine.
poudriere bulk -t for 101i386, 103amd64, 110i386, 93amd64, 93i386, head-amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbeich updated this revision to Diff 23268.Dec 26 2016, 12:31 PM
jbeich retitled this revision from to multimedia/mpv: update to 0.23.0.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: cpm.
jbeich updated this revision to Diff 23269.Dec 26 2016, 12:38 PM

Oops, I didn't notice ENCA was enabled by default. Enable UCHARDET to keep the feature.

cpm edited edge metadata.Dec 26 2016, 1:05 PM

LGTM but using waf-1.9.7 spits out this issue:

+ install /usr/ports/multimedia/mpv/work/stage/usr/local/lib/libmpv.so.1.24.0 (from build/libmpv.so)
* Node /usr/ports/multimedia/mpv/work/stage/usr/local/lib/libmpv.so is created more than once (full message on 'waf -v -v'). The task generators are:
  1. 'mpv' in /usr/ports/multimedia/mpv/work/mpv-0.23.0
  2. 'mpv' in /usr/ports/multimedia/mpv/work/mpv-0.23.0
If you think that this is an error, set no_errcheck_out on the task instance
Waf: Leaving directory `/usr/ports/multimedia/mpv/work/mpv-0.23.0/build'
'install' finished successfully (0.954s)
====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)

Thanks for the update, Jan ;)

cpm added a comment.Dec 26 2016, 1:18 PM

It works like a charm using waf-1.8.22 instead of 1.9.7

So we should build mpv with version 1.8.x

cpm requested changes to this revision.Dec 26 2016, 1:22 PM
cpm edited edge metadata.
cpm added inline comments.
multimedia/mpv/Makefile
21 ↗(On Diff #23269)

We should use waf-1.8.22

This revision now requires changes to proceed.Dec 26 2016, 1:22 PM
jbeich updated this revision to Diff 23271.Dec 26 2016, 1:34 PM
jbeich edited edge metadata.

It works like a charm using waf-1.8.22 instead of 1.9.7

Agree since it's what WRKSRC/bootstrap.py specifies.

Hmm, bootstrap.py actually has 1.8.12, not 1.8.22.

jbeich updated this revision to Diff 23272.Dec 26 2016, 1:38 PM
jbeich edited edge metadata.

Downgrade waf to 1.8.12. I don't think we're interested in upstream fixes on 1.8.x branch atm.

cpm accepted this revision.Dec 26 2016, 1:52 PM
cpm edited edge metadata.
This revision is now accepted and ready to land.Dec 26 2016, 1:52 PM
cpm added a comment.Dec 26 2016, 1:54 PM

Downgrade waf to 1.8.12. I don't think we're interested in upstream fixes on 1.8.x branch atm.

I agree. Please, go ahead and commit mpv update to 0.23.0

This revision was automatically updated to reflect the committed changes.