Page MenuHomeFreeBSD

Cleanup @dirrm* from lang/perl5.*
ClosedPublic

Authored by mat on Oct 2 2014, 9:10 PM.

Details

Reviewers
bapt
Group Reviewers
Perl
Commits
rP369892: Cleanup @dirrm*.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mat updated this revision to Diff 1867.Oct 2 2014, 9:10 PM
mat retitled this revision from to Cleanup @dirrm* from lang/perl5.*.
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: Perl.
mat added a comment.Oct 2 2014, 9:13 PM

Would love someone to test this, otherwise, I'll just

Macro shipit:

bapt added a subscriber: bapt.Oct 2 2014, 10:22 PM
bapt added inline comments.
lang/perl5.14/pkg-plist
3002 ↗(On Diff #1867)

What is the point of this entry? I'm not sure about the below one either
only @dir %%SITE_PERL%% seem interesting

3007 ↗(On Diff #1867)

This would need an alternative as well but that is not the point, I'll bring an alternative soon :)

lang/perl5.20/pkg-plist
2261 ↗(On Diff #1867)

@rmtry?

2262 ↗(On Diff #1867)

god this is dirty, I'd be interested in what other os do here

mat added inline comments.Oct 3 2014, 11:45 AM
lang/perl5.14/pkg-plist
3002 ↗(On Diff #1867)

The point is to have the empty directory exist. Perl modules expect it to be there.

lang/perl5.20/pkg-plist
2261 ↗(On Diff #1867)

Ah, yes, forgot about that one :-)

mat updated this revision to Diff 1870.Oct 3 2014, 11:47 AM

use @rmtry sort better.

bapt accepted this revision.Oct 3 2014, 11:51 AM
bapt added a reviewer: bapt.
This revision is now accepted and ready to land.Oct 3 2014, 11:51 AM
mat added inline comments.Oct 3 2014, 12:24 PM
lang/perl5.14/pkg-plist
3007 ↗(On Diff #1867)

About that, I've been pondering removing this and doing it in post-install, but I would need to generate that bit of plist, and I don't like doing that :-)

mat closed this revision.Oct 3 2014, 12:42 PM
mat updated this revision to Diff 1871.

Closed by commit rP369892 (authored by @mat).