Page MenuHomeFreeBSD

Fix setrlimit_test:setrlimit_memlock when the system has exceeded vm.max_wired.
ClosedPublic

Authored by bdrewery on Dec 1 2016, 10:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 19 2024, 10:41 AM
Unknown Object (File)
Jan 9 2024, 8:31 AM
Unknown Object (File)
Jan 1 2024, 2:42 PM
Unknown Object (File)
Dec 22 2023, 11:25 AM
Unknown Object (File)
Dec 22 2023, 11:24 AM
Unknown Object (File)
Dec 20 2023, 12:46 AM
Unknown Object (File)
Dec 5 2023, 10:16 AM
Unknown Object (File)
Nov 6 2023, 1:55 PM
Subscribers
None

Details

Summary

This uses the same fix as r294894 did for the mlock test. The code from
that commit is moved into a common object file which PROGS supports
building first.

Sponsored by: Dell EMC Isilon

Test Plan
/usr/tests/lib/libc/sys # kyua test setrlimit_test
setrlimit_test:setrlimit_basic  ->  passed  [0.004s]
setrlimit_test:setrlimit_current  ->  passed  [0.004s]
setrlimit_test:setrlimit_err  ->  passed  [0.004s]
setrlimit_test:setrlimit_fsize  ->  passed  [0.004s]
setrlimit_test:setrlimit_memlock  ->  skipped: Required configuration property 'allow_sysctl_side_effects' not defined  [0.002s]
setrlimit_test:setrlimit_nofile_1  ->  passed  [0.005s]
setrlimit_test:setrlimit_nofile_2  ->  passed  [0.005s]
setrlimit_test:setrlimit_nproc  ->  passed  [0.539s]
setrlimit_test:setrlimit_perm  ->  passed  [0.005s]
setrlimit_test:setrlimit_stack  ->  passed  [0.005s]

Results file id is usr_tests_lib_libc_sys.20161201-220229-061447
Results saved to /root/.kyua/store/results.usr_tests_lib_libc_sys.20161201-220229-061447.db

10/10 passed (0 failed)

/usr/tests/lib/libc/sys # kyua test mlock_test
mlock_test:mlock_clip  ->  passed  [0.004s]
mlock_test:mlock_err  ->  skipped: Required configuration property 'allow_sysctl_side_effects' not defined  [0.002s]
mlock_test:mlock_limits  ->  passed  [0.005s]
mlock_test:mlock_mmap  ->  skipped: Required configuration property 'allow_sysctl_side_effects' not defined  [0.002s]
mlock_test:mlock_nested  ->  skipped: Required configuration property 'allow_sysctl_side_effects' not defined  [0.002s]

Results file id is usr_tests_lib_libc_sys.20161201-220634-156194
Results saved to /root/.kyua/store/results.usr_tests_lib_libc_sys.20161201-220634-156194.db

5/5 passed (0 failed)

Enabling the sysctl config:

/usr/tests/lib/libc/sys # kyua test setrlimit_test
setrlimit_test:setrlimit_basic  ->  passed  [0.004s]
setrlimit_test:setrlimit_current  ->  passed  [0.004s]
setrlimit_test:setrlimit_err  ->  passed  [0.004s]
setrlimit_test:setrlimit_fsize  ->  passed  [0.004s]
setrlimit_test:setrlimit_memlock  ->  passed  [0.005s]
setrlimit_test:setrlimit_nofile_1  ->  passed  [0.005s]
setrlimit_test:setrlimit_nofile_2  ->  passed  [0.005s]
setrlimit_test:setrlimit_nproc  ->  passed  [0.539s]
setrlimit_test:setrlimit_perm  ->  passed  [0.004s]
setrlimit_test:setrlimit_stack  ->  passed  [0.004s]

Results file id is usr_tests_lib_libc_sys.20161201-220304-213242
Results saved to /root/.kyua/store/results.usr_tests_lib_libc_sys.20161201-220304-213242.db

10/10 passed (0 failed)

/usr/tests/lib/libc/sys # kyua test mlock_test
mlock_test:mlock_clip  ->  passed  [0.004s]
mlock_test:mlock_err  ->  failed: /root/git/freebsd/contrib/netbsd-tests/lib/libc/sys/t_mlock.c:136: Expected errno 12, got 22, in mlock((char *)-1, page) == -1  [0.004s]
mlock_test:mlock_limits  ->  passed  [0.005s]
mlock_test:mlock_mmap  ->  passed  [0.004s]
mlock_test:mlock_nested  ->  passed  [0.004s]

Results file id is usr_tests_lib_libc_sys.20161201-220643-878354
Results saved to /root/.kyua/store/results.usr_tests_lib_libc_sys.20161201-220643-878354.db

4/5 passed (1 failed)

The mlock_test:mlock_err already exists and is a separate issue.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bdrewery retitled this revision from to Fix setrlimit_test:setrlimit_memlock when the system has exceeded vm.max_wired..
bdrewery updated this object.
bdrewery edited the test plan for this revision. (Show Details)
bdrewery added a reviewer: ngie.
ngie edited edge metadata.
This revision is now accepted and ready to land.Dec 1 2016, 10:10 PM

Sidenote: :mlock_err failing is something that I've known about for a while. It doesn't happen internal to Isilon, but it definitely happens on my workstations/VMs.

This revision was automatically updated to reflect the committed changes.