Page MenuHomeFreeBSD

sysutils/goaccess: bump, adding more options and cleanup
ClosedPublic

Authored by sbz on Nov 29 2016, 1:51 AM.

Details

Summary

This changes contains the following:

  • Add more options
  • Remove unneccessary dependencies
  • Add missing static html files for report generation
  • Add pkg-plist instead PLIST_FILES
  • Cleanup

Since version 0.9.5 dependency to glib is not necessary anymore.

[1] https://github.com/allinurl/goaccess/blob/master/ChangeLog#L186

Test Plan
  • Poudriere

$ for jname in 11amd64 10amd64; do sudo poudriere testport -j $jname -p portsdir -o sysutils/goaccess; done

[2] http://62.210.142.226:8000/10amd64-portsdir/latest/build.html
[3] http://62.210.142.226:8000/11amd64-portsdir/latest/build.html

  • Portlint

$ portlint -a
looks fine.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sbz updated this revision to Diff 22591.Nov 29 2016, 1:51 AM
sbz retitled this revision from to sysutils/goaccess: bump, adding more options and cleanup.
sbz updated this object.
sbz edited the test plan for this revision. (Show Details)
sbz added a reviewer: bapt.
bapt added inline comments.Nov 29 2016, 5:48 AM
sysutils/goaccess/pkg-plist
2 ↗(On Diff #22591)

@sample does not work like that it should be

@sample etc/goaccess.conf.sample

and so you may need to add a post-install target that will move etc/goaaccess.conf into etc/goaccess.conf.sample

sbz updated this revision to Diff 22594.Nov 29 2016, 10:05 AM

Update @sample use

sbz marked an inline comment as done.Nov 29 2016, 10:07 AM

Thank you! Fixed.

bapt edited edge metadata.Nov 29 2016, 1:40 PM

With your latest change I'm pretty sure make check-plist will complain as the install target in the makefile already installs etc/sample.conf in the stagedir. That is why I was saying you should move ${STAGEDIR}${PREFIX}/etc/goaccess.conf into ${STAGEDIR}${PREFIX}/etc/goaccess.conf.sample

mat added a comment.Nov 29 2016, 1:51 PM

All the _CONFIGURE_ON construct should be using the _CONFIGURE_ENABLE or _CONFIGURE_WITH one instead.

sbz updated this revision to Diff 22596.Nov 29 2016, 1:57 PM
sbz edited edge metadata.

Move config as sample because it's already installed by install (through install-am) target

bapt accepted this revision.Nov 29 2016, 2:35 PM
bapt edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2016, 2:35 PM
This revision was automatically updated to reflect the committed changes.