Page MenuHomeFreeBSD

Kick dd out of the build tools club
ClosedPublic

Authored by imp on Nov 21 2016, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 28, 4:41 PM
Unknown Object (File)
Sun, Apr 28, 4:41 PM
Unknown Object (File)
Sun, Apr 28, 4:40 PM
Unknown Object (File)
Sun, Apr 28, 11:34 AM
Unknown Object (File)
Fri, Apr 26, 9:03 AM
Unknown Object (File)
Tue, Apr 16, 6:30 AM
Unknown Object (File)
Tue, Apr 16, 6:30 AM
Unknown Object (File)
Tue, Apr 16, 6:30 AM
Subscribers
None

Details

Summary

Make sure we can use dd status=none before using it. That way, it doesn't have to be a build tool.

Test Plan

compile from older freebsd 10's and see if it works.
10.3R has dd status=none, and it works there when I change it to 'fred=none' in the test (so it doesn't add fred=none, and it doesn't print an obnoxious error message).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp retitled this revision from to Kick dd out of the build tools club.
imp updated this object.
imp edited the test plan for this revision. (Show Details)
imp added a reviewer: emaste.
imp set the repository for this revision to rS FreeBSD src repository - subversion.
sys/boot/Makefile.inc
21 โ†—(On Diff #22411)

Clearly I'd need to change this to status=none for the commit. :)

emaste edited edge metadata.

Looks like a good idea, without fred and perhaps with an update in the comment.

sys/boot/Makefile.inc
19 โ†—(On Diff #22411)

Minor nit, this sounds like status=none was added to the dd command for reproducible builds, not to the individual invocations.

This revision is now accepted and ready to land.Nov 22 2016, 2:03 AM
This revision was automatically updated to reflect the committed changes.