Fix arcgit when run from a worktree

[rstone]

Summary

In a git worktree, the gitdir is in an entirely different location.
Use git rev-parse --git-dir to get the correct path to it always.

[rstone]

Similar fix is needed in importgit

[markj]

tools/tools/git/importgit

98 ↗

(On Diff #22158)

I think the quotation marks are unneeded, FWIW. Ditto in arcgit.

98 ↗

(On Diff #22158)

Hm... this will print the path relative to the -C argument. Shouldn't it be git=${git_dir}/$(git ...) ?

106 ↗

(On Diff #22158)

Looks like this check should come earlier?

[rstone]

tools/tools/git/importgit

98 ↗

(On Diff #22158)

Hm, on my machine I get an absolute path. What version of git do you have? I have 2.8.1.

106 ↗

(On Diff #22158)

Indeed

[markj]

tools/tools/git/importgit

98 ↗

(On Diff #22158)

Lovely, seems like a regression then:

$ cd /
$ git -C /home/markj/src/freebsd-dev rev-parse --git-dir
.git
$ git --version
git version 2.10.1
$

[rstone]

tools/tools/git/importgit

98 ↗

(On Diff #22158)

Nope, I see the same behaviour from a native git tree. It's only work trees that give absolute paths. *sigh*

[markj]

tools/tools/git/importgit

98 ↗

(On Diff #22158)

Compounding my confusion, old-style worktrees created with git-new-workdir also give relative paths.

[rstone]

--git-dir is unreliable, so use -C $git_repo instead

[markj]

I'd consider setting git="git -C $git_repo" and using $git everywhere instead, but this looks like it works.