Page MenuHomeFreeBSD

add infineon adm6996fc support on etherswitch
ClosedPublic

Authored by yamori813_yahoo.co.jp on Nov 11 2016, 12:59 AM.

Details

Summary

add infineon adm6996fc support on etherswitch

Test Plan

check on Netgear WGR614Cv7

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yamori813_yahoo.co.jp retitled this revision from to add infineon adm6996fc support on etherswitch.Nov 11 2016, 12:59 AM
yamori813_yahoo.co.jp updated this object.
yamori813_yahoo.co.jp edited the test plan for this revision. (Show Details)
yamori813_yahoo.co.jp updated this revision to Diff 22137.
mizhka added a subscriber: mizhka.Nov 11 2016, 5:20 AM
  1. I see some "magic" constants. May be worth to add macros.
  2. DPRINTF usage: it prints function name on each call, is it useful/enough useful?
  3. "style(9)": ADM6996FC_READREG/WRITEREG - to be tab instead of space
  4. No checks on malloc results, may be NULL.
  5. Probe: can you add array of IDs to match. In future it will be easy to add IDs into array to bring support of another models.
sys/dev/etherswitch/infineon/adm6996fc.c
721–722 ↗(On Diff #22137)

one empty line is enough ;)

  1. add more macros.

2 This code is same as other ehterswitch code.

  1. add space.
  2. Other etherswitch code not check malloc also...
  3. Check only Product Code.
adrian accepted this revision.
This revision is now accepted and ready to land.Nov 16 2016, 11:43 PM
mizhka accepted this revision.
This revision was automatically updated to reflect the committed changes.