Page MenuHomeFreeBSD

[net80211] extend/add crypto key flags for more key / payload offload. * Add flags to say "don't mmic/iv insert", etc - ath10k firmware and other boards want it. * Move the demic routine into ieee80211_crypto.c and add support for being told...
ClosedPublic

Authored by adrian on Oct 28 2016, 2:08 AM.
Tags
None
Referenced Files
F132700738: D8364.id.diff
Sun, Oct 19, 4:08 AM
F132639239: D8364.id21743.diff
Sat, Oct 18, 4:11 PM
F132639224: D8364.id22023.diff
Sat, Oct 18, 4:10 PM
F132625872: D8364.diff
Sat, Oct 18, 1:23 PM
Unknown Object (File)
Sat, Oct 18, 5:07 AM
Unknown Object (File)
Tue, Oct 14, 12:53 AM
Unknown Object (File)
Aug 14 2025, 8:02 AM
Unknown Object (File)
Jun 29 2025, 7:54 AM
Subscribers

Details

Summary

...that the IV/MIC was stripped and so it can't check with the key, etc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian retitled this revision from to [net80211] extend/add crypto key flags for more key / payload offload. * Add flags to say "don't mmic/iv insert", etc - ath10k firmware and other boards want it. * Move the demic routine into ieee80211_crypto.c and add support for being told....
adrian updated this object.
adrian edited the test plan for this revision. (Show Details)
sys/net80211/ieee80211_crypto.h
81 ↗(On Diff #21743)

just a note - this flag is not set for WPA-NONE / WEP / <other static> keys

93 ↗(On Diff #21743)

I think new flags should be added into IEEE80211_KEY_DEVICE mask - see rS305850

sys/net80211/ieee80211_crypto.h
93 ↗(On Diff #21743)

IEEE80211_KEY_BITS needs to be updated too

sys/net80211/ieee80211_crypto.h
81 ↗(On Diff #21743)

looks like there is off-by-one bug it the sent e-mail - I've marked line 81 (KEY_GROUP) in review, not line 82 (KEY_NOREPLAY)

This revision was automatically updated to reflect the committed changes.