Page MenuHomeFreeBSD
Differential D8364

[net80211] extend/add crypto key flags for more key / payload offload. * Add flags to say "don't mmic/iv insert", etc - ath10k firmware and other boards want it. * Move the demic routine into ieee80211_crypto.c and add support for being told...
ClosedPublic
Actions

Authored by adrian on Oct 28 2016, 2:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 19, 4:08 AM
Unknown Object (File)
Sat, Oct 18, 4:11 PM
Unknown Object (File)
Sat, Oct 18, 4:10 PM
Unknown Object (File)
Sat, Oct 18, 1:23 PM
Unknown Object (File)
Sat, Oct 18, 5:07 AM
Unknown Object (File)
Tue, Oct 14, 12:53 AM
Unknown Object (File)
Aug 14 2025, 8:02 AM
Unknown Object (File)
Jun 29 2025, 7:54 AM
View All 90 Files
Subscribers
avos
imp

Details

Reviewers
avos
Commits
rS308354: [net80211] begin fleshing out new hardware crypto offload features.
Summary

...that the IV/MIC was stripped and so it can't check with the key, etc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian updated this revision to Diff 21743.Oct 28 2016, 2:08 AM
adrian retitled this revision from to [net80211] extend/add crypto key flags for more key / payload offload. * Add flags to say "don't mmic/iv insert", etc - ath10k firmware and other boards want it. * Move the demic routine into ieee80211_crypto.c and add support for being told....
adrian updated this object.
adrian edited the test plan for this revision. (Show Details)
Herald added a subscriber: imp. · View Herald TranscriptOct 28 2016, 2:08 AM
adrian added a reviewer: avos.Oct 28 2016, 2:08 AM
adrian added a subscriber: avos.
avos added inline comments.Oct 29 2016, 8:32 AM
sys/net80211/ieee80211_crypto.h
81 ↗(On Diff #21743)

just a note - this flag is not set for WPA-NONE / WEP / <other static> keys

93 ↗(On Diff #21743)

I think new flags should be added into IEEE80211_KEY_DEVICE mask - see rS305850

avos added inline comments.Oct 29 2016, 8:34 AM
sys/net80211/ieee80211_crypto.h
93 ↗(On Diff #21743)

IEEE80211_KEY_BITS needs to be updated too

avos added inline comments.Oct 29 2016, 8:40 AM
sys/net80211/ieee80211_crypto.h
81 ↗(On Diff #21743)

looks like there is off-by-one bug it the sent e-mail - I've marked line 81 (KEY_GROUP) in review, not line 82 (KEY_NOREPLAY)

Closed by commit rS308354: [net80211] begin fleshing out new hardware crypto offload features. (authored by adrian). · Explain WhyNov 5 2016, 10:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
net80211/
46 lines
55 lines

Diff 22023

View Options

head/sys/net80211/ieee80211_crypto.h

Loading...
View Options

head/sys/net80211/ieee80211_crypto.c

Loading...