Page MenuHomeFreeBSD

Allow using LICENSE_FILE when a port has multiple licenses all in one file.
Needs ReviewPublic

Authored by mat on Oct 7 2016, 7:10 AM.

Details

Reviewers
None
Group Reviewers
portmgr

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5489
Build 5710: arc lint + arc unit

Event Timeline

mat updated this revision to Diff 21133.Oct 7 2016, 7:10 AM
mat retitled this revision from to Allow using LICENSE_FILE when a port has multiple licenses all in one file..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: portmgr.Oct 7 2016, 8:16 AM

The other choice is to give out a warning/error.

jbeich added a subscriber: jbeich.Oct 7 2016, 12:34 PM

The proper support requires adjusting LICENSES_ASK dialog and installing only one file rather than multiple copies of the same file. However, few ports actually have several licenses in one file. In most cases LICENSE_FILE with LICENSE_COMB != single is invalid. Those should be fixed rather than shoved under the carpet.

$ git grep -lF LICENSE_COMB \*/Makefile\* | xargs fgrep -l LICENSE_FILE= | wc -l
     174