Page MenuHomeFreeBSD
Differential D8164

net-im/corebird: Update to 1.3.3
ClosedPublic
Actions

Authored by cpm on Oct 6 2016, 9:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 13, 2:07 PM
Unknown Object (File)
Sat, Jun 13, 1:23 PM
Unknown Object (File)
Sat, Jun 13, 12:13 PM
Unknown Object (File)
Sat, Jun 13, 9:46 AM
Unknown Object (File)
Fri, Jun 12, 8:23 PM
Unknown Object (File)
Mon, Jun 8, 10:44 PM
Unknown Object (File)
May 1 2026, 2:49 PM
Unknown Object (File)
Apr 29 2026, 9:51 AM
View All Files
Subscribers
None

Details

Reviewers
AMDmi3
junovitch
feld
Commits
rP423533: - Update to 1.3.3
Summary
  • Update to 1.3.3 release

Changelog:

https://github.com/baedert/corebird/releases/tag/1.3.3

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cpm updated this revision to Diff 21106.Oct 6 2016, 9:09 AM
cpm retitled this revision from to net-im/corebird: Update to 1.3.3.
cpm updated this object.
cpm edited the test plan for this revision. (Show Details)
cpm added reviewers: AMDmi3, feld, junovitch.
AMDmi3 accepted this revision.Oct 6 2016, 9:42 AM
AMDmi3 edited edge metadata.

LGTM, but you may consider

  • removing pre-configure (just tried manually running autoreconf -fi, it created the directory automatically)
  • adding NLS knob as suggested by portlint
This revision is now accepted and ready to land.Oct 6 2016, 9:42 AM
cpm updated this revision to Diff 21109.Oct 6 2016, 10:19 AM
cpm edited edge metadata.
  • Remove pre-configure target
  • Add NLS knob
This revision now requires review to proceed.Oct 6 2016, 10:19 AM
cpm added a comment.Oct 6 2016, 10:20 AM
In D8164#169362, @AMDmi3 wrote:

LGTM, but you may consider

  • removing pre-configure (just tried manually running autoreconf -fi, it created the directory automatically)
  • adding NLS knob as suggested by portlint

Thanks, Dmitry :)

cpm added a comment.EditedOct 6 2016, 1:28 PM

Gettext consists of developer tools and a runtime component. So you can depend on each separately like this:

USES=gettext-tools
NLS_CONFIGURE_ENABLE=nls
NLS_USES=gettext-runtime

A question arises me:

Given that QA checks claims that corebird depends on gettext-runtime.

Is correct how I've added NLS knob?

cpm updated this revision to Diff 21190.Oct 8 2016, 7:22 PM
cpm edited edge metadata.

I figured out how to make it properly works.

cpm added a comment.Oct 8 2016, 7:23 PM

Tested via poudriere on 9.3/ia, 10.2/ia and 10.3/ia.

All builds are fine.

Closed by commit rP423533: - Update to 1.3.3 (authored by cpm). · Explain WhyOct 8 2016, 7:27 PM
This revision was automatically updated to reflect the committed changes.
cpm mentioned this in rP423533: - Update to 1.3.3.

Revision Contents
Changeset List

PathSize
head/
net-im/
corebird/
16 lines
6 lines
62 lines

Diff 21191

View Options

head/net-im/corebird/Makefile

Loading...
View Options

head/net-im/corebird/distinfo

Loading...
View Options

head/net-im/corebird/pkg-plist

Loading...