Add missing dependencies to audio/linux-c6-{flac,libsndfile,alsa-plugins-pulseaudio,pulseaudio-libs} , fix comments and conflicts in flac
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Commitmessage:
Add missing deps, fix COMMENT/CONFLICTS
Add missing dependencies to audio/linux-c6-{flac,libsndfile,alsa-plugins-pulseaudio,pulseaudio-libs};
set proper COMMENT and CONFLICTS in audio/linux-c6-flac (both of which I missed in r368845).
PR: 193862
Submitted by: Jan Beich <jbeich@vfemail.net>
Approved by: koobs (mentor)Comment Actions
Since its unclear that you are on emulation@, and a blanket does not apply, make it clear in your commit log you are addressing issues you are introduced, and are tidying up.
A clear and documented reason that there is approval for a commit is always prudent. This may be
- Blanket stuff
- Maintainer
- Implicit (you wear the group@ hat, or are a member)
- You maintain it
- There is evidence in a linked issue (and referenced in the commit) that we have approval
Comment Actions
Note that @xmj provided poudriere build logs outside of the review context (on IRC).
Note that test plan section needs to be obvious what QA was completed, and their results. "OK" is fine for each test run if they are successful.
Comment Actions
Please also include the proposed shortlog/commit log in the review summary itself (ideally in code blocks), rather than a comment.
This means that all relevant info needed to approve is right up the top