Page MenuHomeFreeBSD

Add deps, fix conflicts/comments.
ClosedPublic

Authored by xmj on Sep 23 2014, 11:27 AM.

Details

Reviewers
swills
koobs
Summary

Add missing dependencies to audio/linux-c6-{flac,libsndfile,alsa-plugins-pulseaudio,pulseaudio-libs} , fix comments and conflicts in flac

Test Plan

builds ok locally, pulling in the right dependencies

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

xmj updated this revision to Diff 1730.Sep 23 2014, 11:27 AM
xmj retitled this revision from to Add deps, fix conflicts/comments..
xmj updated this object.
xmj edited the test plan for this revision. (Show Details)
xmj added reviewers: koobs, swills.
xmj added a comment.EditedSep 23 2014, 11:30 AM

Commitmessage:

Add missing deps, fix COMMENT/CONFLICTS

Add missing dependencies to audio/linux-c6-{flac,libsndfile,alsa-plugins-pulseaudio,pulseaudio-libs};
set proper COMMENT and CONFLICTS in audio/linux-c6-flac (both of which I missed in r368845).

PR: 193862
Submitted by: Jan Beich <jbeich@vfemail.net>
Approved by: koobs (mentor)
koobs edited edge metadata.Sep 23 2014, 11:45 AM

Since its unclear that you are on emulation@, and a blanket does not apply, make it clear in your commit log you are addressing issues you are introduced, and are tidying up.

A clear and documented reason that there is approval for a commit is always prudent. This may be

  • Blanket stuff
  • Maintainer
  • Implicit (you wear the group@ hat, or are a member)
  • You maintain it
  • There is evidence in a linked issue (and referenced in the commit) that we have approval
koobs accepted this revision.Sep 23 2014, 11:58 AM
koobs edited edge metadata.

LGTM, SHIP IT

This revision is now accepted and ready to land.Sep 23 2014, 11:58 AM

Note that @xmj provided poudriere build logs outside of the review context (on IRC).

Note that test plan section needs to be obvious what QA was completed, and their results. "OK" is fine for each test run if they are successful.

Please also include the proposed shortlog/commit log in the review summary itself (ideally in code blocks), rather than a comment.

This means that all relevant info needed to approve is right up the top

xmj closed this revision.Sep 23 2014, 12:06 PM

Committed revision 369048.