Page MenuHomeFreeBSD

file: report xxHash build-id and display any between 4 and 20 bytes long
ClosedPublic

Authored by emaste on Oct 3 2016, 7:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 24 2024, 9:20 PM
Unknown Object (File)
May 3 2024, 1:47 PM
Unknown Object (File)
Mar 25 2024, 5:58 AM
Unknown Object (File)
Dec 25 2023, 11:41 PM
Unknown Object (File)
Dec 14 2023, 2:41 PM
Unknown Object (File)
Sep 14 2023, 3:45 AM
Unknown Object (File)
Aug 12 2023, 5:47 PM
Unknown Object (File)
Jul 23 2023, 7:35 AM
Subscribers
None

Details

Reviewers
emaste
delphij
Summary

LLVM's lld can generate an 8-byte xxHash Build-ID. Add it to the list of known lengths, and display the content of any Build-ID with a length between 4 and 20 bytes that does not correspond to a known type as "unknown".

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste retitled this revision from to file: report xxHash build-id and display any between 4 and 20 bytes long.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: delphij.

The patch itself seems good, but have you contacted Christos for upstreaming? (He is quite good at adopting our patches, and this would also reduce our future work).

The patch itself seems good, but have you contacted Christos for upstreaming? (He is quite good at adopting our patches, and this would also reduce our future work).

I've tried to subscribe to the file mailing list so I can send patches there, but am waiting to be approved to join the list :(
I can try sending this patch directly to Christos as well.

Christos has committed it to the internal file repository.

I'm not sure when a new release is coming out. Should I commit this change to contrib, or do you want to just wait to have it come in from upstream?

emaste added a reviewer: emaste.

Committed upstream and arrived in FreeBSD in rS308420

This revision is now accepted and ready to land.Nov 7 2016, 5:57 PM