Page MenuHomeFreeBSD
Differential D802

Migrate siba_bwn to use the bus_generic* functions instead of hand-rolled
ClosedPublic
Actions

Authored by jhibbits on Sep 19 2014, 9:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 8, 12:54 AM
Unknown Object (File)
Fri, Nov 7, 5:17 AM
Unknown Object (File)
Wed, Nov 5, 2:08 AM
Unknown Object (File)
Mon, Nov 3, 7:03 AM
Unknown Object (File)
Thu, Oct 30, 8:33 AM
Unknown Object (File)
Thu, Oct 30, 8:33 AM
Unknown Object (File)
Thu, Oct 30, 8:33 AM
Unknown Object (File)
Thu, Oct 30, 4:22 AM
View All Files
Subscribers
None

Details

Reviewers
adrian
Commits
rS300760: [siba] use the generic bus methods where appropriate.
Summary

The siba_bwn_shutdown(), siba_bwn_suspend(), and siba_bwn_resume() duplicate
code, almost verbatim, from bus_generic_*. Migrate to use those instead.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhibbits updated this revision to Diff 1694.Sep 19 2014, 9:26 PM
jhibbits retitled this revision from to Migrate siba_bwn to use the bus_generic* functions instead of hand-rolled.
jhibbits updated this object.
jhibbits edited the test plan for this revision. (Show Details)
jhibbits added a reviewer: adrian.
adrian accepted this revision.Sep 19 2014, 9:27 PM
adrian edited edge metadata.

Looks good. Just test it out on real hardware.

This revision is now accepted and ready to land.Sep 19 2014, 9:27 PM
Closed by commit rS300760: [siba] use the generic bus methods where appropriate. (authored by adrian). · Explain WhyMay 26 2016, 6:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
siba/
44 lines

Diff 16929

View Options

head/sys/dev/siba/siba_bwn.c

Loading...