[iwm] Fix off-by-one check in iwm_read_firmware().
ClosedPublic
Actions

Authored by ivadasz on Sep 18 2016, 9:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 7, 3:00 AM

	Unknown Object (File)
	Wed, May 6, 10:34 PM

	Unknown Object (File)
	Sun, May 3, 5:47 PM

	Unknown Object (File)
	Thu, Apr 30, 2:32 AM

	Unknown Object (File)
	Mon, Apr 27, 12:47 PM

	Unknown Object (File)
	Mon, Apr 27, 1:35 AM

	Unknown Object (File)
	Sun, Apr 26, 11:49 AM

	Unknown Object (File)
	Mon, Apr 20, 11:23 AM

View All Files

Subscribers

imp

Details

Reviewers

cognet
adrian

Commits

rS306001: [iwm] Fix off-by-one check in iwm_read_firmware().

Summary

This fixes a potential buffer overrun in the firmware parsing code.

Reported by: Coverity

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivadasz updated this revision to Diff 20434.Sep 18 2016, 9:26 AM

ivadasz retitled this revision from to [iwm] Fix off-by-one check in iwm_read_firmware()..

ivadasz updated this object.

ivadasz added reviewers: adrian, cognet.

Herald added a subscriber: imp. · View Herald TranscriptSep 18 2016, 9:26 AM

adrian accepted this revision.Sep 19 2016, 9:36 PM

adrian edited edge metadata.

This revision is now accepted and ready to land.Sep 19 2016, 9:36 PM

Closed by commit rS306001: [iwm] Fix off-by-one check in iwm_read_firmware(). (authored by ivadasz). · Explain WhySep 19 2016, 10:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

iwm/

if_iwm.c

2 lines

Diff 20501

View Options

[iwm] Fix off-by-one check in iwm_read_firmware().ClosedPublicActions