Page MenuHomeFreeBSD
Differential D7931

[iwm] Fix off-by-one check in iwm_read_firmware().
ClosedPublic
Actions

Authored by ivadasz on Sep 18 2016, 9:26 AM.
Tags
None
Referenced Files
F173955419: D7931.id20501.diff
Tue, Sep 29, 3:23 PM
Unknown Object (File)
Sun, Sep 27, 5:01 AM
Unknown Object (File)
Fri, Sep 25, 9:52 PM
Unknown Object (File)
Sat, Sep 19, 8:30 PM
Unknown Object (File)
Sat, Sep 12, 9:22 AM
Unknown Object (File)
Aug 21 2026, 9:12 PM
Unknown Object (File)
Aug 21 2026, 9:12 PM
Unknown Object (File)
Aug 21 2026, 9:11 PM
View All Files
Subscribers
imp

Details

Reviewers
cognet
adrian
Commits
rS306001: [iwm] Fix off-by-one check in iwm_read_firmware().
Summary

This fixes a potential buffer overrun in the firmware parsing code.

Reported by: Coverity

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivadasz updated this revision to Diff 20434.Sep 18 2016, 9:26 AM
ivadasz retitled this revision from to [iwm] Fix off-by-one check in iwm_read_firmware()..
ivadasz updated this object.
ivadasz added reviewers: adrian, cognet.
Herald added a subscriber: imp. · View Herald TranscriptSep 18 2016, 9:26 AM
adrian accepted this revision.Sep 19 2016, 9:36 PM
adrian edited edge metadata.
This revision is now accepted and ready to land.Sep 19 2016, 9:36 PM
Closed by commit rS306001: [iwm] Fix off-by-one check in iwm_read_firmware(). (authored by ivadasz). · Explain WhySep 19 2016, 10:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
iwm/
2 lines

Diff 20501

View Options

head/sys/dev/iwm/if_iwm.c

Loading...