Page MenuHomeFreeBSD

net80211: improve error checking in ieee80211_parse_{wpa,rsn}
ClosedPublic

Authored by avos on Sep 13 2016, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 9:47 AM
Unknown Object (File)
Sat, Sep 5, 7:55 PM
Unknown Object (File)
Sat, Sep 5, 8:51 AM
Unknown Object (File)
Fri, Sep 4, 9:47 PM
Unknown Object (File)
Fri, Sep 4, 5:24 PM
Unknown Object (File)
Thu, Sep 3, 11:52 AM
Unknown Object (File)
Thu, Sep 3, 8:51 AM
Unknown Object (File)
Tue, Sep 1, 11:49 PM
Subscribers

Details

Summary
  • Add few checks for group/pairwise ciphers in ieee80211_parse_{wpa,rsn}.
  • Split error code and cipher value in wpa_cipher() / rsn_cipher(); current hack with (1 << 32) does not work - it's 1, not 0 (originally detected by CSA).
  • Return IEEE80211_REASON_UNSUPP_RSN_IE_VERSION instead of IEEE80211_REASON_IE_INVALID when version field is not equal to RSN_VERSION.
Test Plan

Tested with wpi(4) / urtwn(4); no visible regressions.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avos retitled this revision from to net80211: improve error checking in ieee80211_parse_{wpa,rsn}.
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
adrian edited edge metadata.

looks good to me!

This revision is now accepted and ready to land.Sep 13 2016, 10:02 PM
This revision was automatically updated to reflect the committed changes.