Page MenuHomeFreeBSD

Prevent BSS from being cleared twice on BookE
ClosedPublic

Authored by int0dster_gmail.com on Aug 25 2016, 4:49 AM.

Details

Summary

First time BSS is cleared in booke_init(), Second time it cleared in powerpc_init().
Any variable initialized between two those guys gets wiped out what is wrong. In particular
it wipes tlb1_entries initialized by tlb1_init()

Test Plan

Build and boot the kernel

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

int0dster_gmail.com retitled this revision from to Prevent BSS from being cleared twice on BookE.
int0dster_gmail.com updated this object.
int0dster_gmail.com edited the test plan for this revision. (Show Details)
int0dster_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.
int0dster_gmail.com added a project: PowerPC.
jhibbits edited edge metadata.

Great! This was another leftover from the statically cached tlb1, where we would re initialize then reset the tlb. Since we no longer reset the tlb this zeroing is no longer needed, and is instead potentially harmful.

This revision is now accepted and ready to land.Aug 25 2016, 7:31 PM
This revision was automatically updated to reflect the committed changes.