There is no need to call tlb1_init() twice. Now it is called first time from booke_init()
and second time from powerpc_init() (where it is under BOOKE switch). Although this does not cause immediate
problems in the mainline kernel, this can lead to undesirable side effects like two TLB entries with the same
VA in the TLB1. Presence of two TLB entries with the same VA can hang CPU.
Details
Details
- Reviewers
jhibbits - Commits
- rS304656: tlb1_init() can be called twice on BookE
Add initial mapping for UART to the tlb1_init(), build and boot the kernel, ensure that mapping presents
only once (most convinient way - through Lauterbah or similar hardware debugger)
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This was leftovers from when we cached TLB1 entries in an in-memory cache, and needed to call tlb1_init() after the BSS was initialized, to reinitialize the cache.