Page MenuHomeFreeBSD

tlb1_init() can be called twice on BookE
ClosedPublic

Authored by int0dster_gmail.com on Aug 23 2016, 4:16 AM.

Details

Summary

There is no need to call tlb1_init() twice. Now it is called first time from booke_init()
and second time from powerpc_init() (where it is under BOOKE switch). Although this does not cause immediate
problems in the mainline kernel, this can lead to undesirable side effects like two TLB entries with the same
VA in the TLB1. Presence of two TLB entries with the same VA can hang CPU.

Test Plan

Add initial mapping for UART to the tlb1_init(), build and boot the kernel, ensure that mapping presents
only once (most convinient way - through Lauterbah or similar hardware debugger)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

int0dster_gmail.com retitled this revision from to tlb1_init() can be called twice on BookE.
int0dster_gmail.com updated this object.
int0dster_gmail.com edited the test plan for this revision. (Show Details)
int0dster_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.
int0dster_gmail.com added a project: PowerPC.
jhibbits edited edge metadata.

This was leftovers from when we cached TLB1 entries in an in-memory cache, and needed to call tlb1_init() after the BSS was initialized, to reinitialize the cache.

This revision is now accepted and ready to land.Aug 23 2016, 4:31 AM
This revision was automatically updated to reflect the committed changes.