Mk/bsd.port.mk: Fix generic variables in PLIST_SUB_SED regression
AbandonedPublic
Actions

Authored by koobs on Aug 19 2016, 12:12 PM.

Details

Reviewers

koobs
mat

Group Reviewers

O5: Ports Framework	(Owns No Changed Paths)
portmgr

Summary

Mk/bsd.port.mk: Fix generic variables in PLIST_SUB_SED regression

A number of variables that were previously removed from PLIST_SUB_SED for being too
generic, are now present after r420327. This causes pkg-plist entries displayed by
check-stagedir.sh and check_leftover.sh to be over-substituted. 

For example in lang/python36, the LIB32DIR variable is present, replacing every
instance of 'lib':

Error: Orphaned: %%LIB32DIR%%/python%%XYDOT%%/idle%%LIB32DIR%%/tabbedpages.py

In this change:

 * Fix reference to undefined variable (PLIST_SUB_tmp1)
 * Fix reference to incorrect variable (PLIST_SUB_SED_tmp1)

[1] https://svnweb.freebsd.org/ports?view=revision&revision=420327

PR: 211995
Approved by: portmgr
DiffRev: D7580

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4862
Build 4925: arc lint + arc unit

Event Timeline

koobs updated this revision to Diff 19488.Aug 19 2016, 12:12 PM

koobs retitled this revision from to Mk/bsd.port.mk: Fix generic variables present in PLIST_SUB_SED.

koobs updated this object.

koobs edited the test plan for this revision. (Show Details)

koobs added reviewers: portmgr, mat.

Owners added a reviewer: O5: Ports Framework.Aug 19 2016, 12:12 PM

Herald edited edge metadata. · View Herald TranscriptAug 19 2016, 12:12 PM

koobs updated this object.Aug 19 2016, 12:15 PM

koobs edited edge metadata.

koobs retitled this revision from Mk/bsd.port.mk: Fix generic variables present in PLIST_SUB_SED to Mk/bsd.port.mk: Fix regression - Generic variables present in PLIST_SUB_SED.

koobs retitled this revision from Mk/bsd.port.mk: Fix regression - Generic variables present in PLIST_SUB_SED to Mk/bsd.port.mk: Fix generic variables in PLIST_SUB_SED regression.Aug 19 2016, 12:27 PM

koobs updated this object.