Page MenuHomeFreeBSD

xen-netfront: fix trying to send packets with disconnected netfront
ClosedPublic

Authored by royger on Jul 28 2016, 2:12 PM.
Tags
None
Referenced Files
F151659078: D7349.id18879.diff
Thu, Apr 9, 8:15 PM
Unknown Object (File)
Mon, Apr 6, 4:55 PM
Unknown Object (File)
Sun, Apr 5, 1:42 PM
Unknown Object (File)
Sat, Apr 4, 12:59 PM
Unknown Object (File)
Sun, Mar 22, 7:32 AM
Unknown Object (File)
Sun, Mar 22, 3:17 AM
Unknown Object (File)
Thu, Mar 19, 9:35 PM
Unknown Object (File)
Wed, Mar 18, 3:15 PM
Subscribers

Details

Summary

In certain circumstances xn_txq_mq_start might be called with num_queues ==
0 during the resume phase after a migration, which can trigger a KASSERT.
Fix this by making sure the carrier is on before trying to transmit, or else
return that the queues are full.

Just as a note, I haven't been able to reproduce this crash on my test
systems, but I still think it's possible and worth fixing.

Reported by: Karl Pielorz <kpielorz_lst@tdx.co.uk>
Sponsored by: Citrix Systems R&D
MFC after: 1 week

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

royger retitled this revision from to xen-netfront: fix trying to send packets with disconnected netfront.
royger updated this object.
royger edited the test plan for this revision. (Show Details)
royger added a reviewer: liuw_liuw.name.
This revision is now accepted and ready to land.Jul 28 2016, 2:42 PM
This revision was automatically updated to reflect the committed changes.