Page MenuHomeFreeBSD

xen-netfront: fix trying to send packets with disconnected netfront
ClosedPublic

Authored by royger on Jul 28 2016, 2:12 PM.
Tags
None
Referenced Files
F166309967: D7349.diff
Wed, Aug 12, 7:54 PM
Unknown Object (File)
Mon, Aug 10, 9:21 AM
Unknown Object (File)
Sun, Aug 9, 4:33 PM
Unknown Object (File)
Sun, Aug 9, 11:52 AM
Unknown Object (File)
Sat, Aug 8, 5:51 AM
Unknown Object (File)
Jul 7 2026, 5:55 PM
Unknown Object (File)
Jul 7 2026, 1:53 PM
Unknown Object (File)
May 12 2026, 1:11 PM
Subscribers

Details

Summary

In certain circumstances xn_txq_mq_start might be called with num_queues ==
0 during the resume phase after a migration, which can trigger a KASSERT.
Fix this by making sure the carrier is on before trying to transmit, or else
return that the queues are full.

Just as a note, I haven't been able to reproduce this crash on my test
systems, but I still think it's possible and worth fixing.

Reported by: Karl Pielorz <kpielorz_lst@tdx.co.uk>
Sponsored by: Citrix Systems R&D
MFC after: 1 week

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

royger retitled this revision from to xen-netfront: fix trying to send packets with disconnected netfront.
royger updated this object.
royger edited the test plan for this revision. (Show Details)
royger added a reviewer: liuw_liuw.name.
This revision is now accepted and ready to land.Jul 28 2016, 2:42 PM
This revision was automatically updated to reflect the committed changes.