Modernize x11/xdm

[ak]

Summary

• Use options helpers
• The pkg_tools are dead, so use @dirrm(try) with absolute path and remove as many @unexec/@exec as possible

Test Plan

Apply the patch. Build port in poudriere with testport / bulk -t.

[bapt]

Can you hold a bit this one?

pkg 1.3.8 is coming next week and will clean up all this a bit more

[ak]

Sure, I'll wait.

[jhale]

Options helper conversion is a little off. You want: XDMSHELL_CONFIGURE_ENABLE= xdmshell

Style-wise, I'd block OPTIONS_SUB underneath OPTIONS_DEFINE and block XDMSHELL_DESC with XDMSHELL_CONFIGURE_ENABLE.

[ak]

Options helper conversion is a little off. You want: XDMSHELL_CONFIGURE_ENABLE= xdmshell

Fixed, thanks.

Style-wise, I'd block OPTIONS_SUB underneath OPTIONS_DEFINE and block XDMSHELL_DESC with XDMSHELL_CONFIGURE_ENABLE.

Hmm, is it documented somewhere?

[ak]

• Use options helpers (properly)
• Convert to @sample
• Strip lib(s)
• Use new @dir syntax
• Remove as many @unexec/@exec as possible

[bapt]

x11/xdm/pkg-plist

22 ↗

(On Diff #1757)

couldn't @rmtry deal with this?

[ak]

22 couldn't @rmtry deal with this?

Oh, it somehow reverted to original, it should be: @unexec rm -rf /var/lib/xdm/authdir/* 2>/dev/null || true
Because directory name can be authfiles.? and authfile name is A*.
I was not able to find a way to delete file/dir with unknown name without @unexec rm. Will be glad to hear any suggestions.

[ak]

• Use INSTALL_TARGET=install-strip instead of STRIP_CMD

[ak]

Closed by commit rP369334 (authored by @ak).