Page MenuHomeFreeBSD

Modernize x11/xdm
ClosedPublic

Authored by ak on Sep 5 2014, 2:44 PM.

Details

Reviewers
bapt
kwm
jhale
Group Reviewers
x11
Commits
rP369334: - Use options helpers
Summary
  • Use options helpers
  • The pkg_tools are dead, so use @dirrm(try) with absolute path and remove as many @unexec/@exec as possible
Test Plan

Apply the patch. Build port in poudriere with testport / bulk -t.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ak retitled this revision from to Modernize x11/xdm.
ak updated this object.
ak edited the test plan for this revision. (Show Details)
ak added reviewers: x11, kwm.
ak set the repository for this revision to rP FreeBSD ports repository.

Can you hold a bit this one?

pkg 1.3.8 is coming next week and will clean up all this a bit more

jhale requested changes to this revision.Sep 16 2014, 2:54 PM
jhale added a reviewer: jhale.
jhale added a subscriber: jhale.

Options helper conversion is a little off. You want: XDMSHELL_CONFIGURE_ENABLE= xdmshell

Style-wise, I'd block OPTIONS_SUB underneath OPTIONS_DEFINE and block XDMSHELL_DESC with XDMSHELL_CONFIGURE_ENABLE.

This revision now requires changes to proceed.Sep 16 2014, 2:54 PM

Options helper conversion is a little off. You want: XDMSHELL_CONFIGURE_ENABLE= xdmshell

Fixed, thanks.

Style-wise, I'd block OPTIONS_SUB underneath OPTIONS_DEFINE and block XDMSHELL_DESC with XDMSHELL_CONFIGURE_ENABLE.

Hmm, is it documented somewhere?

ak edited edge metadata.
  • Use options helpers (properly)
  • Convert to @sample
  • Strip lib(s)
  • Use new @dir syntax
  • Remove as many @unexec/@exec as possible
x11/xdm/pkg-plist
22 ↗(On Diff #1757)

couldn't @rmtry deal with this?

22 couldn't @rmtry deal with this?

Oh, it somehow reverted to original, it should be: @unexec rm -rf /var/lib/xdm/authdir/* 2>/dev/null || true
Because directory name can be authfiles.? and authfile name is A*.
I was not able to find a way to delete file/dir with unknown name without @unexec rm. Will be glad to hear any suggestions.

bapt added a reviewer: bapt.
ak edited edge metadata.
  • Use INSTALL_TARGET=install-strip instead of STRIP_CMD
kwm edited edge metadata.
ak updated this revision to Diff 1792.

Closed by commit rP369334 (authored by @ak).